From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ingo Lohmar Newsgroups: gmane.emacs.devel Subject: Re: include new package wconf.el in GNU ELPA Date: Thu, 30 Jul 2015 22:58:59 +0200 Message-ID: <871tfp8ir0.fsf@acer.localhost.com> References: <877fph8xwx.fsf@acer.localhost.com> <87d1z9a210.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1438289968 7023 80.91.229.3 (30 Jul 2015 20:59:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 30 Jul 2015 20:59:28 +0000 (UTC) Cc: emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 30 22:59:23 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZKuvC-0002gb-Ba for ged-emacs-devel@m.gmane.org; Thu, 30 Jul 2015 22:59:22 +0200 Original-Received: from localhost ([::1]:41941 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKuvB-00074S-DO for ged-emacs-devel@m.gmane.org; Thu, 30 Jul 2015 16:59:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKuuz-00072t-6c for emacs-devel@gnu.org; Thu, 30 Jul 2015 16:59:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKuuy-0001yg-06 for emacs-devel@gnu.org; Thu, 30 Jul 2015 16:59:09 -0400 Original-Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:38034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKuus-0001wj-8e; Thu, 30 Jul 2015 16:59:02 -0400 Original-Received: by wibxm9 with SMTP id xm9so7493989wib.1; Thu, 30 Jul 2015 13:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=8USu1sznqyoXkJ1JvXQzvD3C+EU3EogZQGZPBN6j5kw=; b=SkCg4drtOqmLfJRntTCk5RLiPj0CGfrqDIkWcGeKpiNqJ5SbTUwRqS2//ZhuwT2EFw 0TrPlspP8hLU9CCCsI9MP0na6M5l0DA4wZj7VQMaJ7755ulBJBggrv67vQDqYmh0Ceik ONsTnR4aS6L0dnWfU0d6mF1ndPugIRn+UErzHTr0LfaSRBM6r7aGXbtpNF3QZIWwABTN NvRQ54iCdv1VGT1te4gbpruZk1vbsCzeQVi8jKAzyALh36BFZJ/qeJlwyHQ6LZjP8QSy uDtFin5ypeHFKf38SuBQb0dOwHcmRg1kSZqrflQqMWPPjPe2z4hqjSG+VjgY9Tb55mw4 1LCw== X-Received: by 10.180.198.178 with SMTP id jd18mr139590wic.14.1438289941411; Thu, 30 Jul 2015 13:59:01 -0700 (PDT) Original-Received: from localhost (xdsl-87-79-132-17.netcologne.de. [87.79.132.17]) by smtp.gmail.com with ESMTPSA id r6sm955836wiy.13.2015.07.30.13.59.00 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jul 2015 13:59:00 -0700 (PDT) In-Reply-To: <87d1z9a210.fsf@gnu.org> User-Agent: Notmuch/0.19+110~gb2cc2a6 (http://notmuchmail.org) Emacs/25.0.50.1 (x86_64-unknown-linux-gnu) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188206 Archived-At: On Thu, Jul 30 2015 21:17 (+0200), Tassilo Horn wrote: > Ingo Lohmar writes: > > Hi Ingo, > >> I've been using my small single-purpose package wconf.el >> https://github.com/ilohmar/wconf for a while now and I am very happy >> with it. The code is all mine and I have signed the FSF papers. Now >> I would like to put it into an elpa for visibility --- is it ok if I >> upload it into the GNU elpa (I have commit rights)? > > Then I think all prerequisites are set. > >> The package does nothing but offer a simple mechanism to switch >> between different window configurations of a single frame, and to >> persist them across sessions. > > Looks simple and useful. I'll try it out when I find some spare time. > I seldomly use window configurations mainly because I don't like that > window configs also restore point and selected window. Basically, I'd > prefer that when I restore a window config, the point values stay as > they are for all the buffers which are part of the current window config > and the one I'm switching to. Likewise, I'd like to have the window > selected which displays the same buffer as the selected window in the > current window config in case the window config I'm switching to also > has a window displaying that buffer. Does wconf have a knob for that? > (If not and you add one, you have a new user for sure. :-)) > > One comment on the code: I dislike the practice of having a normal > package name and then use an abbreviated prefix in the actual code. > wconf is a short name anyway, so IMHO there is no benefit of defining > the functions and variables with the abbreviated wc- prefix instead of > wconf-. But there is the obvious downside of likely clashes with > private stuff from users with the initials WC. So I'd suggest to change > that before it pops up in the package list and people start using, > configuring, and extending it. > > A similar thing applies to the file where window configs are stored > which is currently window-configs.el. I'd rather go with something > which makes the connection to your package completely obvious, e.g., > wconf-window-configs.el. > > Bye, > Tassilo Hi Tassilo, Thanks for your comments! I have some showstoppers to fix that Dmitry spotted, and then I'll think about the prefix stuff and will probably change it. I have not thought about the point and window business yet, so there's no option. Generally I am wary of dealing with window-config details (which I did in a much earlier version of the package), but this seems like a general and useful switch to have.. Maybe I will add that. It would help me if you could add a github issue describing the option behavior, otherwise I'll try to keep a note myself. Bye, Ingo