From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#21435: 25.0.50; file-notify has problems after renames Date: Wed, 09 Sep 2015 22:23:05 +0200 Message-ID: <871te7tk9i.fsf@gnu.org> References: <87y4gh47sr.fsf@gnu.org> <83k2s07vaf.fsf@gnu.org> <87fv2ovlcr.fsf@gmx.de> <83613k7owe.fsf@gnu.org> <87si6og17z.fsf@gnu.org> <877fnzv4r6.fsf@gmx.de> <87egi7o1s1.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1441830277 4743 80.91.229.3 (9 Sep 2015 20:24:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Sep 2015 20:24:37 +0000 (UTC) Cc: 21435@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 09 22:24:22 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZZlun-0002cY-Mg for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Sep 2015 22:24:21 +0200 Original-Received: from localhost ([::1]:45581 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZlun-00005h-AH for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Sep 2015 16:24:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZluZ-0008PX-Jf for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2015 16:24:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZluU-0007rL-JV for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2015 16:24:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZluU-0007rH-GQ for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2015 16:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZZluU-0000BO-7a for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2015 16:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Sep 2015 20:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21435 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21435-submit@debbugs.gnu.org id=B21435.1441830193637 (code B ref 21435); Wed, 09 Sep 2015 20:24:02 +0000 Original-Received: (at 21435) by debbugs.gnu.org; 9 Sep 2015 20:23:13 +0000 Original-Received: from localhost ([127.0.0.1]:54229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZZltg-0000AD-Dq for submit@debbugs.gnu.org; Wed, 09 Sep 2015 16:23:12 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:48810) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZZlte-0000A3-Km for 21435@debbugs.gnu.org; Wed, 09 Sep 2015 16:23:11 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 3E1F2201E3 for <21435@debbugs.gnu.org>; Wed, 9 Sep 2015 16:23:09 -0400 (EDT) Original-Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Wed, 09 Sep 2015 16:23:09 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=v2mjNlnq5UaKL9ztOIvTMMt/mGM=; b=f4jcs eX4KWKnSDe4SJAlFxGPWK/YBL8n9A7bKumH3Fu5RpGmVfzOdjhh7Gxq+Jq7i2N+d RW2aReSvQYtEXPnrrQpFGCbOBKsdQF9WolUeTu66nkkyfmvxJ4oZmQSoRJWUO3Wl 2ElXQmiw41sTHK0JN7scUb9+CCaOPXF+H4bWcM= X-Sasl-enc: EziZOoRMfvNozVgfPADMslJPKbUOvU+hFx2clt8GTg25 1441830188 Original-Received: from thinkpad-t440p (unknown [2.161.206.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 2F83DC00020; Wed, 9 Sep 2015 16:23:08 -0400 (EDT) In-Reply-To: <87egi7o1s1.fsf@gnu.org> (Tassilo Horn's message of "Wed, 09 Sep 2015 21:01:18 +0200") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106326 Archived-At: Tassilo Horn writes: >> Even the straigt forward cases are not covered well in >> file-notify-tests.el. There is a test whether events arrive, but the >> nature of the events is not asserted. >> >> You could try with what you expect, at least for inotify, and Eli and >> I could check then for the gfilenotify and w32notify cases. If we >> have the same results, fine; if we have different results it would be >> a good chance for us to harmonize. > > That's right. I'll try adding some tests whenever I find some time. Ok, I gave it a whirl and now the `file-notify--test-event-handler' also records all events in a new variable `file-notify--test-events' for later analysis. `file-notify-test02-events' now uses that feature to check if the received events are the expected ones in the expected order. That already revealed two problems: 1. Now `file-notify-test02-events-remote' fails because after every expected `changed' event an additional `attribute-changed' event is received. This is wrong because when adding the watch, only '(change) is given as FLAGS argument, not '(change attribute-change). 2. When I change the watch FLAGS to '(change attribute-change), there are still no attribute-changed events received in the local case. And a question: Will the events read by `file-notify--wait-for-events' still be processed by the handler function? And what's the intention of (file-notify--wait-for-events 5 file-notify--test-results)? The timeout of 5 is reasonable, but the UNTIL argument here just defines that it waits until the very first of possibly up to nine yet missing events is awaited here, or do I get something wrong? Bye, Tassilo