From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: [PATCH] Search for more cover image names in MPC Date: Sun, 11 Oct 2015 11:18:02 -0400 Message-ID: <871td14eol.fsf@udel.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1444576722 5816 80.91.229.3 (11 Oct 2015 15:18:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 11 Oct 2015 15:18:42 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 11 17:18:32 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZlIOM-0006DK-Vn for ged-emacs-devel@m.gmane.org; Sun, 11 Oct 2015 17:18:31 +0200 Original-Received: from localhost ([::1]:48662 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlIOM-00043R-5w for ged-emacs-devel@m.gmane.org; Sun, 11 Oct 2015 11:18:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlIOI-00043C-L1 for emacs-devel@gnu.org; Sun, 11 Oct 2015 11:18:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlIOF-00033S-CJ for emacs-devel@gnu.org; Sun, 11 Oct 2015 11:18:26 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:49681) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlIOF-00033K-56 for emacs-devel@gnu.org; Sun, 11 Oct 2015 11:18:23 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1ZlIO6-00060S-MU for emacs-devel@gnu.org; Sun, 11 Oct 2015 17:18:14 +0200 Original-Received: from c-73-172-248-173.hsd1.md.comcast.net ([73.172.248.173]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 11 Oct 2015 17:18:14 +0200 Original-Received: from mvoteiza by c-73-172-248-173.hsd1.md.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 11 Oct 2015 17:18:14 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 40 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: c-73-172-248-173.hsd1.md.comcast.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Cancel-Lock: sha1:CJJlv/AS0w6wGeSdv7pvjSr+Hnw= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:191237 Archived-At: * lisp/mpc.el (mpc-format): Also look for .folder.jpg or folder.jpg case insensitively --- The downcase isn't necessary, I just thought it would be nice to allow things cased differently. At least in my library, I seem to have a handful of capitalized folder images. lisp/mpc.el | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lisp/mpc.el b/lisp/mpc.el index bc7d473..0178712 100644 --- a/lisp/mpc.el +++ b/lisp/mpc.el @@ -44,7 +44,6 @@ ;; - visual feedback for drag'n'drop ;; - display/set `repeat' and `random' state (and maybe also `crossfade'). ;; - allow multiple *mpc* sessions in the same Emacs to control different mpds. -;; - look for .folder.png (freedesktop) or folder.jpg (XP) as well. ;; - fetch album covers and lyrics from the web? ;; - improve MPC-Status: better volume control, add a way to show/hide the ;; rest, plus add the buttons currently in the toolbar. @@ -1010,7 +1009,11 @@ If PLAYLIST is t or nil or missing, use the main playlist." time))))) (`Cover (let* ((dir (file-name-directory (cdr (assq 'file info)))) - (cover (concat dir "cover.jpg")) + (covers '(".folder.png" "cover.jpg" "folder.jpg")) + (cover (cl-flet ((coverp (fn) + (member (downcase fn) covers))) + (cl-loop for file in (directory-files dir) + if (coverp file) return file))) (file (with-demoted-errors "MPC: %s" (mpc-file-local-copy cover))) image) -- 2.6.1