From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: taylanbayirli@gmail.com (Taylan Ulrich =?utf-8?Q?Bay=C4=B1rl=C4=B1?= =?utf-8?Q?=2FKammer?=) Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add shell-quasiquote. Date: Sat, 17 Oct 2015 23:27:54 +0200 Message-ID: <871tctuqw5.fsf@T420.taylan> References: <87si59wj42.fsf@T420.taylan> <83eggt4esi.fsf@gnu.org> <87fv19wh7b.fsf@T420.taylan> <83bnbx4d7e.fsf@gnu.org> <87twppuzfu.fsf@T420.taylan> <83a8rh48if.fsf@gnu.org> <87io65utmt.fsf@T420.taylan> <5622B3C6.4030208@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1445117287 8236 80.91.229.3 (17 Oct 2015 21:28:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 17 Oct 2015 21:28:07 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 17 23:28:06 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZnZ1I-0002Rf-0R for ged-emacs-devel@m.gmane.org; Sat, 17 Oct 2015 23:28:04 +0200 Original-Received: from localhost ([::1]:59815 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnZ1G-0006Sx-Tv for ged-emacs-devel@m.gmane.org; Sat, 17 Oct 2015 17:28:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnZ1D-0006Ss-PW for emacs-devel@gnu.org; Sat, 17 Oct 2015 17:28:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZnZ1B-0002k6-3u for emacs-devel@gnu.org; Sat, 17 Oct 2015 17:27:57 -0400 Original-Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:34539) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnZ1A-0002jz-Sx for emacs-devel@gnu.org; Sat, 17 Oct 2015 17:27:57 -0400 Original-Received: by wikq8 with SMTP id q8so4398973wik.1 for ; Sat, 17 Oct 2015 14:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type:content-transfer-encoding; bh=QjsSGerRyAYnD8ZmeJ8FuR1jFJVymeX4hfPlvbhBUYQ=; b=bY5I3S/j85d5G8SLsEMjMGePHK+IfDmAUK8N31+pX4OxZhugig2gY6qfeu9WfLCdEN VXLI+MjmkjBH5WMN+rzwfbmyLe+vpSUmB7oyhyu3U4wnbSuQ8Ep0gxkx5uGdk4ZrJyNV 129e+9VQUgotM9ERXKXujL2djhm05t5DllXGm66+vUk4kCmELyHSluOXOBgZwXLTqzVd peod2az7u23szURrjK30NTPzrA0N3kr2GBPPpgnHQGoOfsOtnApOTOnrenS0r/oLFqkM 05n6qZ/z2roj8r+DHEgDBmXU1FSfetmVGD8wjznmN+fiz6qCfQKAtciaWPeTrDLiKAQA fasQ== X-Received: by 10.180.198.174 with SMTP id jd14mr3327411wic.2.1445117276378; Sat, 17 Oct 2015 14:27:56 -0700 (PDT) Original-Received: from T420.taylan ([2a02:908:c32:4740:221:ccff:fe66:68f0]) by smtp.gmail.com with ESMTPSA id m9sm8501888wib.13.2015.10.17.14.27.55 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Oct 2015 14:27:55 -0700 (PDT) In-Reply-To: <5622B3C6.4030208@cs.ucla.edu> (Paul Eggert's message of "Sat, 17 Oct 2015 13:47:02 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:191887 Archived-At: Paul Eggert writes: > Taylan Ulrich Bay=C4=B1rl=C4=B1/Kammer wrote: >> You seem to be implying that using shell-quote-argument will uphold the >> invariant that the code is safe against injection. I'm asking for >> explicit confirmation of that. > > Yes, it's safe. In contrast, the version you proposed is not safe for > really weird csh-like shells, where it can mishandle '!'. It doesn't attempt to work for any shells other than POSIX. Not mentioning this strongly enough in the documentation is a bug; I'll fix it. Determining it automatically is probably impossible I'm afraid, since even on a foreign system one might have a Unix shell installed through Cygwin, if I'm not mistaken. Taylan