* bug#22160: 24.5; "M-x browse-url-emacs" on a 404 page
@ 2015-12-13 10:39 Alex Kost
2015-12-19 10:01 ` Eli Zaretskii
0 siblings, 1 reply; 2+ messages in thread
From: Alex Kost @ 2015-12-13 10:39 UTC (permalink / raw)
To: 22160
Hello, I've noticed an unhandled error when I tried the following:
1. emacs -Q
2. M-x browse-url-emacs RET http://hydra.gnu.org/build/12345
And the error is:
find-file-noselect-1: Wrong type argument: arrayp, nil
As (file-truename buffer-file-name) fails when buffer-file-name is nil.
It would be good to have a more "friendly" error, like the one that
(url-insert-file-contents "http://hydra.gnu.org/build/12345") produces.
Thanks.
--
Alex
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#22160: 24.5; "M-x browse-url-emacs" on a 404 page
2015-12-13 10:39 bug#22160: 24.5; "M-x browse-url-emacs" on a 404 page Alex Kost
@ 2015-12-19 10:01 ` Eli Zaretskii
0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2015-12-19 10:01 UTC (permalink / raw)
To: Alex Kost; +Cc: 22160-done
> From: Alex Kost <alezost@gmail.com>
> Date: Sun, 13 Dec 2015 13:39:13 +0300
>
> Hello, I've noticed an unhandled error when I tried the following:
>
> 1. emacs -Q
> 2. M-x browse-url-emacs RET http://hydra.gnu.org/build/12345
>
> And the error is:
>
> find-file-noselect-1: Wrong type argument: arrayp, nil
>
> As (file-truename buffer-file-name) fails when buffer-file-name is nil.
>
> It would be good to have a more "friendly" error, like the one that
> (url-insert-file-contents "http://hydra.gnu.org/build/12345") produces.
browse-url-emacs is not supposed to display error messages for URLs
that don't exist or cannot be accessed. That function is a fancy way
of visiting a "file buffer" with the HTML source of the URL, so it
should react like "C-x C-f" when the file does not exist. "C-x C-f"
says "New file" and shows an empty buffer; browse-url-emacs's
equivalent is IMO a buffer with the error returned by the server, in
this case the standard 404 response.
So this is what I did in commit bcf4913 on the emacs-25 branch. The
previous code in url-insert-file-contents signaled an error when it
received one of the 4xx responses, disregarding the VISIT argument,
which was a mistake (introduced when we fixed bug#16733, where VISIT
is nil). Now it follows more closely the behavior of
insert-file-contents in that case.
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-19 10:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-13 10:39 bug#22160: 24.5; "M-x browse-url-emacs" on a 404 page Alex Kost
2015-12-19 10:01 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.