From: phillip.lord@russet.org.uk (Phillip Lord)
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Glenn Morris <rgm@gnu.org>, Eli Zaretskii <eliz@gnu.org>,
emacs-devel@gnu.org
Subject: Re: reftex.el autoloads
Date: Fri, 18 Dec 2015 20:55:24 +0000 [thread overview]
Message-ID: <871tajiiir.fsf@russet.org.uk> (raw)
In-Reply-To: <56743E61.8060102@cs.ucla.edu> (Paul Eggert's message of "Fri, 18 Dec 2015 09:12:01 -0800")
Paul Eggert <eggert@cs.ucla.edu> writes:
> On 12/18/2015 08:39 AM, Glenn Morris wrote:
>> Somewhat disappointed, but obviously I'm in a minority.
>> Anyway, it doesn't build. Did you test it?
>
> Yes, I suggest reverting the change from master until it's tested and known to
> work from a fresh checkout.
>
> Here are a couple of other comments. That's not the right way to declare
> autoloads-force to be phony.
I thought it was an usual usage, but I copied it from autoloads. I
guess:
autoloads-force .PHONY:
rm loaddefs.el
$(MAKE) autoloads
should be
autoloads-force:
rm loaddefs.el
$(MAKE) autoloads
.PHONY: autoloads-force
> Also, there shouldn't need to be an autoloads-force at all: if some
> other files need to be built they should be listed as dependencies of
> autoload.
Indeed. It's always been this way, though -- from a non-bootstrap on
emacs-25 try
rm lisp/eshell/esh-groups.el
make
./src/emacs -Q
M-x eshell
It will crash. What you actually have to do is
cd lisp
rm loaddefs.el
make autoloads
The problem is that files are not dependencies, they are targets which
are build at the same time as loaddefs.el. AFAICT, there is no good way
of dealing with this in make (and perhaps there should be).
It is fixable, but it requires significant modifications to
autoloads.el, and will substantially complicate lisp/Makefile.in. I
didn't want to make that change, for fear of disappointing Glenn
further.
This is a minimal change, and was quite useful was I was producing my
(ill-tested) set of commits.
Phil
next prev parent reply other threads:[~2015-12-18 20:55 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 11:03 reftex.el autoloads Phillip Lord
2015-12-10 14:48 ` Artur Malabarba
2015-12-10 16:28 ` Eli Zaretskii
2015-12-10 18:52 ` Paul Eggert
2015-12-10 22:07 ` Phillip Lord
2015-12-11 7:26 ` Eli Zaretskii
2015-12-11 15:38 ` Phillip Lord
2015-12-10 22:03 ` Phillip Lord
2015-12-11 7:24 ` Eli Zaretskii
2015-12-11 15:35 ` Phillip Lord
2015-12-11 16:18 ` Eli Zaretskii
2015-12-11 17:08 ` Phillip Lord
2015-12-11 17:46 ` Glenn Morris
2015-12-11 18:20 ` Phillip Lord
2015-12-11 20:03 ` Paul Eggert
2015-12-12 18:24 ` Phillip Lord
2015-12-12 18:42 ` Eli Zaretskii
2015-12-12 18:56 ` Phillip Lord
2015-12-12 19:09 ` Eli Zaretskii
2015-12-12 21:15 ` Phillip Lord
2015-12-13 3:33 ` Eli Zaretskii
2015-12-13 20:33 ` Phillip Lord
2015-12-13 21:50 ` Glenn Morris
2015-12-13 22:11 ` Phillip Lord
2015-12-15 19:33 ` Glenn Morris
2015-12-16 17:15 ` Phillip Lord
2015-12-17 2:15 ` Glenn Morris
2015-12-17 3:42 ` Eli Zaretskii
2015-12-17 16:07 ` John Wiegley
2015-12-17 21:31 ` Phillip Lord
2015-12-18 16:39 ` Glenn Morris
2015-12-18 17:12 ` Paul Eggert
2015-12-18 20:55 ` Phillip Lord [this message]
2015-12-18 21:27 ` Eli Zaretskii
2015-12-18 21:51 ` Phillip Lord
2015-12-19 7:29 ` Eli Zaretskii
2015-12-18 22:05 ` Phillip Lord
2015-12-19 7:31 ` Eli Zaretskii
2015-12-19 13:24 ` Phillip Lord
2015-12-20 12:41 ` Phillip Lord
2015-12-20 15:59 ` Eli Zaretskii
2015-12-20 18:41 ` Phillip Lord
2015-12-20 18:37 ` Glenn Morris
2015-12-20 23:04 ` Phillip Lord
2015-12-21 0:24 ` Glenn Morris
2015-12-21 10:32 ` Phillip Lord
2015-12-22 10:55 ` Phillip Lord
2015-12-21 6:45 ` martin rudalics
2015-12-21 10:31 ` Phillip Lord
2015-12-18 20:45 ` Phillip Lord
2015-12-18 21:22 ` Phillip Lord
2015-12-20 18:41 ` Glenn Morris
2015-12-20 19:05 ` Eli Zaretskii
2015-12-21 0:22 ` Glenn Morris
2015-12-20 23:15 ` Phillip Lord
2015-12-21 0:29 ` Glenn Morris
2015-12-21 10:52 ` Phillip Lord
2015-12-17 5:57 ` Paul Eggert
2015-12-17 12:07 ` Phillip Lord
2015-12-11 17:34 ` David Engster
2015-12-11 17:39 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tajiiir.fsf@russet.org.uk \
--to=phillip.lord@russet.org.uk \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.