all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jan Tatarik <jan.tatarik@gmail.com>
To: Lars Magne Ingebrigtsen <lmi@gnus.org>
Cc: help-gnu-emacs@gnu.org, Kostas Zorbadelos <kzorba@otenet.gr>
Subject: Re: gnus-icalendar errors in emacs 24.5
Date: Tue, 23 Feb 2016 11:13:38 +0100	[thread overview]
Message-ID: <871t83bup9.fsf@xing.com> (raw)
In-Reply-To: <87y4acurrt.fsf@gnus.org> (Lars Magne Ingebrigtsen's message of "Tue, 23 Feb 2016 12:41:58 +1100")

[-- Attachment #1: Type: text/plain, Size: 802 bytes --]

On Tue, Feb 23 2016, Lars Magne Ingebrigtsen wrote:

[...]

> This is definitely a bug, and it comes from here:

> (cl-defmethod gnus-icalendar-event:org-timestamp ((event gnus-icalendar-event))
>   "Build `org-mode' timestamp from EVENT start/end dates and recurrence info."
>   (let* ((start (gnus-icalendar-event:start-time event))
>          (end (gnus-icalendar-event:end-time event))
>          (start-date (format-time-string "%Y-%m-%d %a" start))

> %a is the locale's day name, and that's not something `date-to-time' can
> parse.  But I'm not familiar with gnus-icalendar, so I'm not sure what
> the right fix is here.

> Jan, is the week day supposed to be in these date strings at all?

How about this? It's a patch against the emacs-25 branch, I was not able
to connect to the gnus git. 


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-diff, Size: 851 bytes --]

diff --git a/lisp/gnus/gnus-icalendar.el b/lisp/gnus/gnus-icalendar.el
index 4faef06..82a649f 100644
--- a/lisp/gnus/gnus-icalendar.el
+++ b/lisp/gnus/gnus-icalendar.el
@@ -401,8 +401,8 @@ gnus-icalendar-event:org-timestamp
          (end-time (format-time-string "%H:%M" end))
          (end-at-midnight (string= end-time "00:00"))
          (start-end-date-diff (/ (float-time (time-subtract
-                                        (date-to-time end-date)
-                                        (date-to-time start-date)))
+                                        (org-time-string-to-time end-date)
+                                        (org-time-string-to-time start-date)))
                                  86400))
          (org-repeat (gnus-icalendar-event:org-repeat event))
          (repeat (if org-repeat (concat " " org-repeat) ""))

  parent reply	other threads:[~2016-02-23 10:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.5404.1456174176.843.help-gnu-emacs@gnu.org>
2016-02-23  1:41 ` gnus-icalendar errors in emacs 24.5 Lars Magne Ingebrigtsen
2016-02-23  9:13   ` Kostas Zorbadelos
2016-02-23 10:13   ` Jan Tatarik [this message]
2016-02-23 10:16     ` Lars Ingebrigtsen
2016-02-23 10:35       ` gnus-icalendar errors in emacs 24.5 [FIXED] Kostas Zorbadelos
2016-02-23 14:25         ` gnus-icalendar errors in emacs 24.5 [timezone issue] Kostas Zorbadelos
2016-02-22 18:48 gnus-icalendar errors in emacs 24.5 Kostas Zorbadelos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871t83bup9.fsf@xing.com \
    --to=jan.tatarik@gmail.com \
    --cc=help-gnu-emacs@gnu.org \
    --cc=kzorba@otenet.gr \
    --cc=lmi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.