From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Marcin Borkowski Newsgroups: gmane.emacs.bugs Subject: bug#20663: page.el (forward-page): Avoid skipping pages Date: Sat, 09 Apr 2016 20:16:47 +0200 Message-ID: <871t6eve9c.fsf@mbork.pl> References: <20150526171440.GG647@gmail.com> <87h9fbum2w.fsf@mbork.pl> <83h9fbhu0p.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1460225835 14765 80.91.229.3 (9 Apr 2016 18:17:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 9 Apr 2016 18:17:15 +0000 (UTC) Cc: 20663@debbugs.gnu.org, ambrevar@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 09 20:17:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aoxRW-0005dQ-DK for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Apr 2016 20:17:10 +0200 Original-Received: from localhost ([::1]:60941 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoxRV-00079H-I4 for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Apr 2016 14:17:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41059) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoxRR-00076O-06 for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 14:17:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoxRN-0000yF-Pp for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 14:17:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43998) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoxRN-0000yB-MR for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 14:17:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1aoxRN-00044z-IE for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 14:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Marcin Borkowski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Apr 2016 18:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20663 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20663-submit@debbugs.gnu.org id=B20663.146022581515663 (code B ref 20663); Sat, 09 Apr 2016 18:17:01 +0000 Original-Received: (at 20663) by debbugs.gnu.org; 9 Apr 2016 18:16:55 +0000 Original-Received: from localhost ([127.0.0.1]:56334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aoxRG-00044Z-QR for submit@debbugs.gnu.org; Sat, 09 Apr 2016 14:16:55 -0400 Original-Received: from mail.mojserwer.eu ([195.110.48.8]:42231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aoxRF-00044Q-6b for 20663@debbugs.gnu.org; Sat, 09 Apr 2016 14:16:53 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 00194AA92D1; Sat, 9 Apr 2016 20:16:51 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Original-Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oh6zz4V8KJdg; Sat, 9 Apr 2016 20:16:48 +0200 (CEST) Original-Received: from localhost (98-171.echostar.pl [213.156.98.171]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 7D044AA92CE; Sat, 9 Apr 2016 20:16:48 +0200 (CEST) User-agent: mu4e 0.9.13; emacs 25.1.50.8 In-reply-to: <83h9fbhu0p.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116282 Archived-At: On 2016-04-09, at 12:00, Eli Zaretskii wrote: >> From: Marcin Borkowski >> Date: Sat, 09 Apr 2016 12:13:11 +0200 >> Cc: 20663@debbugs.gnu.org >> >> On 2015-05-26, at 19:14, Pierre Neidhardt wrote: >> >> > When `page-delimiter` starts at the beginning of the line and the position is >> > also at the beginning of the line, calling `forward-page` will skip one page. >> > >> > Running `emacs -Q example.txt`: >> > >> > M-< >> > C-x n p >> > M-> >> > M-1 C-x n p >> > >> > This should bring us from page 1 to page 2, but page 3 gets displayed instead. >> > >> > The attached patch fixes it by changing the code to actually match its >> > surrounding comments. >> >> Hi Emacs devs, >> >> could someone take a look at the proposed patch? It is not installed as >> of GNU Emacs 25.1.50.8 (commit 1e8cd05), and I don't feel competent >> enough to be sure it does not have any adverse side effects. > > Maybe I'm missing something, but I don't see the connection between > the description of the bug, the recipe, and the patch. > > The description talks about calling forward-page, but the recipe > doesn't call it. The patch compares page-delimiter with an empty > string, but the default value of page-delimiter is not empty. > > So I'm mightily confused by this. Hopefully, someone will show me > what I'm missing. Well, I quickly glanced over the patch and decided that even if it worked for me, I wouldn't be sure whether it doesn't break something else. Since you claim it rather won't work, I'm now tempted to look at this issue more closely. Hopefully I'll be able to come up with a better patch in a few days. Best, -- Marcin Borkowski http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski Faculty of Mathematics and Computer Science Adam Mickiewicz University