From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.bugs Subject: bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request Date: Mon, 08 Aug 2016 09:32:44 -0400 Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos Message-ID: <871t1zcrnn.fsf@lifelogs.com> References: <83d1ltq3p6.fsf@gnu.org> <83popsocg8.fsf@gnu.org> <7fb3540a-7b74-68cf-2c63-66474de26640@yandex.ru> <83mvkvmbv2.fsf@gnu.org> <27168f12-32d2-cb38-45c0-27d3339c75aa@yandex.ru> <83twf0lb5s.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1470664221 24899 195.159.176.226 (8 Aug 2016 13:50:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 8 Aug 2016 13:50:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: stakemorii@gmail.com, 24117@debbugs.gnu.org, larsi@gnus.org To: Dmitry Gutov , Katsumi Yamaoka Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 08 15:50:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bWkwW-00051f-Kg for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Aug 2016 15:50:12 +0200 Original-Received: from localhost ([::1]:57542 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWkwT-00074N-C1 for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Aug 2016 09:50:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWkg0-0007W0-1U for bug-gnu-emacs@gnu.org; Mon, 08 Aug 2016 09:33:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bWkfu-00067P-Oo for bug-gnu-emacs@gnu.org; Mon, 08 Aug 2016 09:33:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWkfu-00067F-Ln for bug-gnu-emacs@gnu.org; Mon, 08 Aug 2016 09:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bWkfu-0004Lf-CB for bug-gnu-emacs@gnu.org; Mon, 08 Aug 2016 09:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ted Zlatanov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Aug 2016 13:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24117-submit@debbugs.gnu.org id=B24117.147066318116708 (code B ref 24117); Mon, 08 Aug 2016 13:33:02 +0000 Original-Received: (at 24117) by debbugs.gnu.org; 8 Aug 2016 13:33:01 +0000 Original-Received: from localhost ([127.0.0.1]:59663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bWkft-0004LQ-4x for submit@debbugs.gnu.org; Mon, 08 Aug 2016 09:33:01 -0400 Original-Received: from mail-pa0-f41.google.com ([209.85.220.41]:36394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bWkfq-0004LA-PR for 24117@debbugs.gnu.org; Mon, 08 Aug 2016 09:32:59 -0400 Original-Received: by mail-pa0-f41.google.com with SMTP id pp5so114025979pac.3 for <24117@debbugs.gnu.org>; Mon, 08 Aug 2016 06:32:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version; bh=CswhTy/PPyEhp8e7G0Bn6f8F6d8xQBuitcl+8FHAdTc=; b=cE4e3h5f9G7zJryTfFR41nlU4IJemJ/2kFFGgldhvHi0U/VETEhj2fQl6RcnCMPZ2G 7WCu/+rpCJ2i/XCtrmNOc3p9RliYfoRZnWdj72q187IM6d25QC19helTbypn20zeuHof jP0yIyWDTgTNsRsR+tW7S1eqPS/mZewkE7YnA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version; bh=CswhTy/PPyEhp8e7G0Bn6f8F6d8xQBuitcl+8FHAdTc=; b=Cara4AXBjWVRvlTeZokB7NqbHZg80f6dLFn9nMyPVeXDfw5aY6lYLw3rOVJCI2+HHT VoBCdhxfgPy1s9lazIAPC0513sS7dDCGIOcbTYLwDNp9f/wpLu4hvkxpbboc+PoHLQ/L Je3AwEF3mM1PVbaX6AFdESc+yOB5ZBkATpt0NP2QmTEZgzw//sFtGJL7Lyd5JPCGiNIz ysbU7M3SRS7n0j1cASuBQisJQmmfKNVnF7xg3YkJsEEKljqDHoL0iYbyc11hhWeuu+kJ Ysx7yFkNTCqbvi/lG6ss5AaD9usg2ZyKNJnFHvoN+jLEgb2ix2yUYPozsEvgNER8rLed oLZw== X-Gm-Message-State: AEkoouszzbygdxw4ZAFNbDxEuv2pwdi9hw0VuIYaY6FgHOdvJskXkg3L4wfBu8XqWIp1vQ== X-Received: by 10.66.8.163 with SMTP id s3mr63955794paa.142.1470663172867; Mon, 08 Aug 2016 06:32:52 -0700 (PDT) Original-Received: from flea (c-98-229-60-157.hsd1.ma.comcast.net. [98.229.60.157]) by smtp.gmail.com with ESMTPSA id p64sm48385906pfd.11.2016.08.08.06.32.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Aug 2016 06:32:52 -0700 (PDT) X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: (Dmitry Gutov's message of "Mon, 8 Aug 2016 04:56:58 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121961 Archived-At: On Mon, 8 Aug 2016 04:56:58 +0300 Dmitry Gutov wrote: DG> Hi Eli, DG> On 08/04/2016 08:02 PM, Eli Zaretskii wrote: >> Hmm, but url-generic-parse-url is called from gazillion other places, >> so maybe this is not safe. DG> Only about 40 places, all of them either in lisp/url or lisp/gnus. Sadly, Lars DG> is being silent on the matter. DG> It might not be 100% safe, but maybe doing TRT could be enough. Lars tends to work in batches (from experience) so waiting on him can take a while. Looking at the discussion, I think the change is OK. I've CC-ed Katsumi Yamaoka since he may have some feedback as well. If this is pushed, since it's a fairly low-level change, it should include a test for the specific issue it fixes (I didn't see that in the discussion so far). Then if we need to tune the code further, we'll have something to keep us from creating a regression. Thanks Ted