From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?iso-8859-9?Q?G=F6ktu=F0_Kayaalp?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Enable customisation for electric-quote-mode chars Date: Mon, 29 Aug 2016 20:19:34 +0300 Message-ID: <871t171oih.fsf@xi.bootis> References: <838tvfbkcb.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1472490584 23780 195.159.176.226 (29 Aug 2016 17:09:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 29 Aug 2016 17:09:44 +0000 (UTC) Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 29 19:09:39 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1beQ3y-00059O-Or for ged-emacs-devel@m.gmane.org; Mon, 29 Aug 2016 19:09:34 +0200 Original-Received: from localhost ([::1]:44920 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beQ3w-0008VL-9v for ged-emacs-devel@m.gmane.org; Mon, 29 Aug 2016 13:09:32 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beQ3m-0008Tg-4m for emacs-devel@gnu.org; Mon, 29 Aug 2016 13:09:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1beQ3k-0007pv-Lp for emacs-devel@gnu.org; Mon, 29 Aug 2016 13:09:22 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:46339) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beQ3f-0007ow-Mv; Mon, 29 Aug 2016 13:09:15 -0400 Original-Received: from mfilter24-d.gandi.net (mfilter24-d.gandi.net [217.70.178.152]) by relay2-d.mail.gandi.net (Postfix) with ESMTP id E7C8CC5A49; Mon, 29 Aug 2016 19:08:52 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter24-d.gandi.net Original-Received: from relay2-d.mail.gandi.net ([IPv6:::ffff:217.70.183.194]) by mfilter24-d.gandi.net (mfilter24-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id QQq6w9K7josi; Mon, 29 Aug 2016 19:08:50 +0200 (CEST) X-Originating-IP: 78.181.205.50 Original-Received: from localhost (unknown [78.181.205.50]) (Authenticated sender: self@gkayaalp.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id D23C2C5A53; Mon, 29 Aug 2016 19:08:49 +0200 (CEST) In-Reply-To: <838tvfbkcb.fsf@gnu.org> (message from Eli Zaretskii on Mon, 29 Aug 2016 19:39:32 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.70.183.194 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206890 Archived-At: > From: Eli Zaretskii > Date: 2016-08-29 07:39:32 PM +0300 > Eli Zaretskii wrote: >> From: G=C3=B6ktu=C4=9F Kayaalp >> Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org >> Date: Mon, 29 Aug 2016 19:27:42 +0300 >>=20 >> > From: Eli Zaretskii >> > Date: 2016-08-29 06:08:25 PM +0300 >> > Eli Zaretskii wrote: >> >> From: G=C3=B6ktu=C4=9F Kayaalp >> >> Cc: eliz@gnu.org, emacs-devel@gnu.org >> >> Date: Mon, 29 Aug 2016 08:28:19 +0300 >>=20 >> (I'm sorry for /borrowing/ your citation style, but it's very nice, I >> couldn't refuse. Hope that doesn't annoy you :) I've made it a bit >> different though.) > > It's not me, it's Rmail that's doing this. (No, I'm not annoyed, of > course not.) I use rmail too, but I had already my cit. line customized some time ago when I used Gnus, so I didn't se this format until now. I'll wait and follow the thread for at least a couple days for comments, and if I don't have the chance earlier, I'll post an updated patch on Saturday. >> >> +quote characters. It's possible to change the default quotes listed >> >> +above, by customizing the variable @code{electric-quote-chars}, a li= st >> >> +of four characters, where the items correspond to the left single >> >> +quote, the right single quote, the left double quote and the right >> >> +double quote, respectively, whose default value is >> >> +@code{'(?=E2=80=98 ?=E2=80=99 ?=E2=80=9C ?=E2=80=9D)}. >> > >> > There's no need to go to such detail when describing a customizable >> > option. The Customize interface should be enough for the user to >> > figure out what to do. >>=20 >> Then I can remove the part after reference to the variable name, and >> improve the defcustom's documentation (see below). Is that okay? > > Yes. > >> > Default (=E2=80=98..=E2=80=99 =E2=80=9C..=E2=80=9D) >> > Arabic (".." =E2=80=9D..=E2=80=9C) >> > German (=E2=80=9A..=E2=80=9B =E2=80=9E..=E2=80=9C) >> > French (=E2=80=B9..=E2=80=BA =C2=AB..=C2=BB) >> > Cyrillic (=E2=80=9A..=E2=80=98 =C2=AB..=C2=BB) >> > >> > etc. WDYT? (See https://en.wikipedia.org/wiki/Quotation_mark for >> > some more.) >>=20 >> Well I think we'd rather not do that but improve the docstring instead, >> because, looking at the big summary table on the page you linked [1] >> there's not only a lot of variance among languages, but some of them >> have multiple standard and alternative forms, and some don't have single >> quotes (e.g. Persian). I think we'd better keep the defaults and >> improve the documentation, and not have implement all the languages nor >> have to pick a subset. > > If no one else thinks my suggestion is a significant improvement, I > won't insist. (And of course, we don't need to implement the entire > Wikipedia list, I'm not even sure it's accurate.) > > It could be enough to mention some of the possibilities in the doc > string, together with their cultural affiliations. > >> Maybe we could leave setting these variables to the language environment >> if that's possible? > > I think it's too early for that, we haven't yet figured out how to set > up language dependent settings. One problem with the idea you raise > is that a user can reside in a certain locale, but use universal > settings commonly used in multilingual environments. > >> Please direct me on how to proceed, and I'll update the patch as soon as >> I can > > I would suggest to wait for a couple of days for more comments. If no > one supports my suggestions about language-tagged alternatives, you > can disregard them, and only make the documentation changes already > mentioned. > > Thanks. > Best, -goktug. --=20 =C4=B0. G=C3=B6ktu=C4=9F Kayaalp. http://gkayaalp.com/