From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] url: Wrap cookie headers in url-http--encode-string. Date: Thu, 08 Sep 2016 19:43:41 +0200 Message-ID: <871t0ui8xe.fsf@toke.dk> References: <20160907153014.15752-1-toke@toke.dk> <87inu7k5z4.fsf@toke.dk> <83bmzzaawr.fsf@gnu.org> <877fank1oc.fsf@toke.dk> <87inu6iim8.fsf@toke.dk> <2563921f-d20d-753b-09eb-c8671bc5b6d6@yandex.ru> <87a8fiidso.fsf@toke.dk> <83oa3y8g0x.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1473357969 14649 195.159.176.226 (8 Sep 2016 18:06:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 8 Sep 2016 18:06:09 +0000 (UTC) Cc: emacs-devel@gnu.org, monnier@iro.umontreal.ca, dgutov@yandex.ru To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 08 20:05:57 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bi3hw-0002Ce-Vl for ged-emacs-devel@m.gmane.org; Thu, 08 Sep 2016 20:05:53 +0200 Original-Received: from localhost ([::1]:50173 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi3hv-00066V-4W for ged-emacs-devel@m.gmane.org; Thu, 08 Sep 2016 14:05:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi3Md-0001RF-0K for emacs-devel@gnu.org; Thu, 08 Sep 2016 13:43:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bi3Mb-0008Jg-Ta for emacs-devel@gnu.org; Thu, 08 Sep 2016 13:43:50 -0400 Original-Received: from mail2.tohojo.dk ([77.235.48.147]:47498) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi3MY-0008J2-H9; Thu, 08 Sep 2016 13:43:46 -0400 X-Virus-Scanned: amavisd-new at mail2.tohojo.dk DKIM-Filter: OpenDKIM Filter v2.10.3 mail2.tohojo.dk 387D840D5E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=201310; t=1473356622; bh=ppntR3l4o8H2poLSiHWmXlc1TuDTy4dSHKGKID/VdQU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=M05f3RIgMNf9SjCTjGkYw9CseiqHeHFG+WtfFS2BX6HoGncgJrz32CcxpQ9l/0m87 EUymr785togMFWU6ZSg7ym8FjF8iP+ze4r2UFqMo1xBRPPDN62nILb+hijfrqPqkqD qZ4efNfPuGhl7KyafkZ7WuMwxz/dOc4syW45+SWg= Original-Received: by alrua-kau.kau.toke.dk (Postfix, from userid 1000) id 2DEA1C4027D; Thu, 8 Sep 2016 19:43:41 +0200 (CEST) In-Reply-To: <83oa3y8g0x.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 08 Sep 2016 20:20:30 +0300") X-Clacks-Overhead: GNU Terry Pratchett X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.235.48.147 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207293 Archived-At: Eli Zaretskii writes: >> From: Toke H=C3=B8iland-J=C3=B8rgensen >> Cc: Eli Zaretskii , monnier@iro.umontreal.ca, emacs-devel@= gnu.org >> Date: Thu, 08 Sep 2016 17:58:31 +0200 >>=20 >> (url-retrieve-synchronously "http://google.se") ; sets a cookie >> (let* ((url-request-data (encode-coding-string "=C3=A6=C3=B8=C3=A5" 'utf= -8))) >> (url-retrieve-synchronously "http://google.se")) ; crashes > > Can the cookies file include non-ASCII text? E.g., could the domain > be non-ASCII? >>From glancing at the code, it seems those are the non-puny-coded hostnames that are stored in that file. But that doesn't really matter, as those are only lookup variables in an the array. The question is whether the cookie values themselves can be. As for that, well...: http://stackoverflow.com/questions/1969232/allowed-characters-in-cookies My reading of that is in most cases they will be. But really, it depends on what the url code itself accepts; of which I have no idea. -Toke