From: npostavs@users.sourceforge.net
To: Tom Tromey <tom@tromey.com>
Cc: 6806@debbugs.gnu.org
Subject: bug#6806: another reason for the patch
Date: Sat, 04 Feb 2017 16:21:41 -0500 [thread overview]
Message-ID: <871svdps7u.fsf@users.sourceforge.net> (raw)
In-Reply-To: <874m0xhsp9.fsf@tromey.com> (Tom Tromey's message of "Tue, 17 Jan 2017 21:56:18 -0700")
Tom Tromey <tom@tromey.com> writes:
> Hi. I'd like to resurrect this bug.
>
> While working in JS I found a bug, which I tracked down to the same
> change indicated here. Basically, auto-fill in JS mode will sometimes
> insert a "/*" on a filled line, where it should not.
>
> You can see a precise recipe in the new test case, in the attached
> patch.
>
> One funny thing is that if you do this interactively (in my real-world
> case I had auto-fill-mode enabled), you have to be sure that there isn't
> a newline after point. If there is a newline, the filling works
> properly.
>
> Anyway, let me know what you think. I'd like to check this in, but,
> given the comments in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=6806#23
> I suppose I would not close the bug.
Sorry I missed this before you pushed the patch, but I'm not sure this
is a bug. If I revert the setting of `comment-multi-line' then with
your test scenario, the result of auto fill is
/* test test test test test test test test test test test test test */
/* test test test
So the opened comment was correctly terminated, and a new one started,
just as documented. Perhaps you don't like that `comment-multi-line' is
nil by default, but it doesn't look like a bug to me.
next prev parent reply other threads:[~2017-02-04 21:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-05 18:36 bug#6806: Set comment-multi-line in js-mode Nathan Weizenbaum
2010-08-08 20:40 ` Chong Yidong
2010-08-09 0:14 ` Nathan Weizenbaum
2010-08-09 11:33 ` Stefan Monnier
2010-08-09 17:56 ` Nathan Weizenbaum
2010-09-11 13:54 ` Stefan Monnier
2010-09-28 18:11 ` Chong Yidong
2017-01-18 4:56 ` bug#6806: another reason for the patch Tom Tromey
2017-02-04 21:21 ` npostavs [this message]
2017-02-04 21:34 ` npostavs
2017-02-11 15:19 ` Tom Tromey
2017-02-12 4:21 ` npostavs
2017-02-12 6:16 ` Tom Tromey
2017-02-15 4:50 ` npostavs
2017-02-04 20:29 ` bug#6806: checked in " Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871svdps7u.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=6806@debbugs.gnu.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.