From: Thien-Thi Nguyen <ttn@gnu.org>
To: emacs-devel@gnu.org
Subject: Re: [elpa] master 550ae83 1/2: [gnugo int] Decruft: Don't declare hook and keymap vars.
Date: Fri, 10 Feb 2017 06:15:04 +0100 [thread overview]
Message-ID: <871sv6mxt3.fsf@zigzag.favinet> (raw)
In-Reply-To: <jwvshnnw8ny.fsf-monnier+gmane.emacs.devel@gnu.org> (Stefan Monnier's message of "Thu, 09 Feb 2017 13:02:22 -0500")
[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]
() Stefan Monnier <monnier@iro.umontreal.ca>
() Thu, 09 Feb 2017 13:02:22 -0500
> (defvar MODE-map INIT) ; model C
> (define-derived-mode MODE ...)
This is the idiomatic form.
OK, noted.
The main benefit is that there's a clear place where the mode
map is defined and `C-h o` will get you there.
Thanks for the tip. ‘C-h o’ is new to me. That's indeed a nice
benefit.
aesthetic problem is due
to the use forward references.
So, is it fair to say that the reason for the patch was to
avoid those forward references?
Yes, exactly.
> (unless EXPECTED-MODE-map-BINDING
Of course, this misfires if the user wants to change this
EXPECTED-MODE-map-BINDING binding ;-)
True, that's the risk.
I'll release, wait a year or two for complaints, and revisit the
decision then -- perhaps ‘C-h o’ will in the meantime learn how
to accomodate some non-idiomatic forms, such as this one.
--
Thien-Thi Nguyen -----------------------------------------------
(defun responsep (query)
(pcase (context query)
(`(technical ,ml) (correctp ml))
...)) 748E A0E8 1CB8 A748 9BFA
--------------------------------------- 6CE4 6703 2224 4C80 7502
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2017-02-10 5:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170208091858.6699.16542@vcs.savannah.gnu.org>
[not found] ` <20170208091858.F26CA220010@vcs.savannah.gnu.org>
2017-02-08 22:28 ` [elpa] master 550ae83 1/2: [gnugo int] Decruft: Don't declare hook and keymap vars Stefan Monnier
2017-02-09 17:39 ` Thien-Thi Nguyen
2017-02-09 18:02 ` Stefan Monnier
2017-02-10 5:15 ` Thien-Thi Nguyen [this message]
2017-02-14 14:04 ` Stefan Monnier
2017-02-16 9:41 ` Thien-Thi Nguyen
2017-02-12 11:12 ` Philipp Stephani
2017-02-13 7:29 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sv6mxt3.fsf@zigzag.favinet \
--to=ttn@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.