From: Michael Albinus <michael.albinus@gmx.de>
To: phillip.lord@russet.org.uk (Phillip Lord)
Cc: Rasmus <rasmus@gmx.us>, emacs-devel@gnu.org
Subject: Re: Merging Org tests
Date: Tue, 14 Feb 2017 20:16:33 +0100 [thread overview]
Message-ID: <871sv01t2m.fsf@gmx.de> (raw)
In-Reply-To: <87lgt8myhm.fsf@russet.org.uk> (Phillip Lord's message of "Tue, 14 Feb 2017 18:13:57 +0000")
phillip.lord@russet.org.uk (Phillip Lord) writes:
>> Also, how strictly must the suggested file organization be followed?
>> Skimming "make-test-deps.emacs-lisp" it seems it might have to be followed
>> rather strictly.
>
> It depends what you want. make-test-deps.emacs-lisp is there so that
> "make check-maybe" can work sanely to run (some approximation of) just
> those tests that need running. I thought this was a good thing to have,
> because "make check" takes too long to run in a commit hook.
In general it is a good thing (tm). But there shall be
improvements. Currently, if you want to run foo-tests.el, it depends on
foo.el. Often, this is sufficient. But for larger packages, like Org or
Tramp, this is not sufficient. So it might be good to maintain a list of
foo*.el files, a test file foo-tests.el shall depend on.
>> What would be the best strategy for including the Org tests in the Emacs
>> repo?
>>
>> 1. Include Org tests in the "manual" folder and keep the current structure.
>> 2. Start to reorganize the tests in the Org repo to follow the Emacs
>> scheme.
>> 3. Keep tests in the Org repo.
>
> Really be good to get tests in into main, so not 3. That's the main
> thing.
Like Eli, I'm in favor of 2.
And pls mark expensive tests with the tag `expensive'. We should teach
elpa's "make check" to skip expensive tests, as we do in emacs' "make
check".
> Phil
Best regards, Michael.
next prev parent reply other threads:[~2017-02-14 19:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 15:10 Merging Org tests Rasmus
2017-02-14 16:20 ` Eli Zaretskii
2017-02-14 18:13 ` Phillip Lord
2017-02-14 19:16 ` Michael Albinus [this message]
2017-02-15 10:55 ` Phillip Lord
2017-02-15 11:32 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sv01t2m.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=phillip.lord@russet.org.uk \
--cc=rasmus@gmx.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.