From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: master 089b159 02/12: change calc to use derived-mode-p Date: Wed, 05 Apr 2017 21:39:27 -0400 Message-ID: <871st648mo.fsf@holos> References: <20170405221727.14496.89482@vcs0.savannah.gnu.org> <20170405221729.6CD8B210A4@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1491442816 29721 195.159.176.226 (6 Apr 2017 01:40:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 6 Apr 2017 01:40:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Tom Tromey To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 06 03:40:12 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cvwP5-0006Ll-Ba for ged-emacs-devel@m.gmane.org; Thu, 06 Apr 2017 03:40:03 +0200 Original-Received: from localhost ([::1]:43070 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvwPB-0003lF-9p for ged-emacs-devel@m.gmane.org; Wed, 05 Apr 2017 21:40:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43169) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvwOc-0003l5-D3 for emacs-devel@gnu.org; Wed, 05 Apr 2017 21:39:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvwOY-00040d-ED for emacs-devel@gnu.org; Wed, 05 Apr 2017 21:39:34 -0400 Original-Received: from mail-qt0-x235.google.com ([2607:f8b0:400d:c0d::235]:36791) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cvwOY-00040S-8g for emacs-devel@gnu.org; Wed, 05 Apr 2017 21:39:30 -0400 Original-Received: by mail-qt0-x235.google.com with SMTP id r45so25551610qte.3 for ; Wed, 05 Apr 2017 18:39:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Iunx8CCtm5/r+7ixU/3CivPDRNykhEzZfmn0baAfvKo=; b=RUoE0hnVIDTM2sQlutIsqeIqvZI8s6qhVwB8hmj2mGHY/0Ir0XDL8hUMxv48wsF0hS lti5wEfTGhQxc9AHHarBDRDjli6s+iLBxHgQUvS4bRUgSh/3MaUJX24XYTECdUpBHt/P CvBaUrpnSlRmfrY5bR265hpyUl4ChMEH1PA+DE7EUeXahYV/uqFd1YBgzy1gZIbJtYqC piF3bfSUXsqk4OGE682bq67w7tO/k1+iZ7KR0utWR4XCaCpaDGsu9iX9HF/B30q69jZS WnXBGo3MTBCYO1ZWesmhWJzHQzuebWBPaJo6vdQQiSACRymrR96NcTJTWre0K9ncsZKD qL6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Iunx8CCtm5/r+7ixU/3CivPDRNykhEzZfmn0baAfvKo=; b=dOBPytVBeNNEIH7V/gsN01VtaLwNS2rPz+0aKir9MM0pQfNUJCGa2y9zmu+CdGWkbr 1JtAx4NnVCowoYzYWpRElifU6OvzW7llkAUgLrrC77xh2EPV58rOMOZdTMBh7KJ4ueyk JQ+TStdZZKA9yKQosABTPSkaWCGoqS8CA31KdxbmoHdXE3v4ST0SOLr5sIZknRfrys+W F0v2kHliXlGtxjguL50JhrFlfTk8038C0M94kfRRVwqNSxeXFOxjXcu+uDePSEpcfqq/ WYI25ELsjmMF6A/XKGOPZzgTDODxcDfoyw8o5ptfM1yiImXjjDQPiES8IQB4iPaPiwwX I0eA== X-Gm-Message-State: AFeK/H2kYtRgZ5JgQRc0vwLFR/cTZG0zZxGLIeUS5qoOFIZvIy24CoaOuuFgLDDE5Cd0Ygfx X-Received: by 10.200.2.150 with SMTP id p22mr34875534qtg.197.1491442768716; Wed, 05 Apr 2017 18:39:28 -0700 (PDT) Original-Received: from holos.localdomain (pool-96-234-164-232.bltmmd.fios.verizon.net. [96.234.164.232]) by smtp.gmail.com with ESMTPSA id i125sm57458qkf.52.2017.04.05.18.39.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Apr 2017 18:39:28 -0700 (PDT) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 2289E66126; Wed, 5 Apr 2017 21:39:27 -0400 (EDT) In-Reply-To: <20170405221729.6CD8B210A4@vcs0.savannah.gnu.org> (Tom Tromey's message of "Wed, 5 Apr 2017 18:17:29 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c0d::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213688 Archived-At: tom@tromey.com (Tom Tromey) writes: > change calc to use derived-mode-p > > * lisp/calc/calc-embed.el (calc-embedded-find-modes) > (calc-embedded-make-info): Use derived-mode-p. > --- > lisp/calc/calc-embed.el | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/lisp/calc/calc-embed.el b/lisp/calc/calc-embed.el > index bb37d7f..bd5601b 100644 > --- a/lisp/calc/calc-embed.el > +++ b/lisp/calc/calc-embed.el > @@ -804,7 +804,7 @@ The command \\[yank] can retrieve it from there." > (backward-char 6)) > (goto-char save-pt) > (unless (assq 'the-language modes) > - (let ((lang (assoc major-mode calc-language-alist))) > + (let ((lang (cl-assoc-if #'derived-mode-p calc-language-alist))) > (if lang > (setq modes (cons (cons 'the-language (cdr lang)) > modes))))) > At first sight: neither calc, viper, nor align use cl-lib, so these changes break things.