all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mark Oteiza <mvoteiza@udel.edu>
To: emacs-devel@gnu.org
Cc: Tom Tromey <tom@tromey.com>
Subject: Re: master 089b159 02/12: change calc to use derived-mode-p
Date: Wed, 05 Apr 2017 21:39:27 -0400	[thread overview]
Message-ID: <871st648mo.fsf@holos> (raw)
In-Reply-To: <20170405221729.6CD8B210A4@vcs0.savannah.gnu.org> (Tom Tromey's message of "Wed, 5 Apr 2017 18:17:29 -0400 (EDT)")

tom@tromey.com (Tom Tromey) writes:

>     change calc to use derived-mode-p
>     
>     * lisp/calc/calc-embed.el (calc-embedded-find-modes)
>     (calc-embedded-make-info): Use derived-mode-p.
> ---
>  lisp/calc/calc-embed.el | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/lisp/calc/calc-embed.el b/lisp/calc/calc-embed.el
> index bb37d7f..bd5601b 100644
> --- a/lisp/calc/calc-embed.el
> +++ b/lisp/calc/calc-embed.el
> @@ -804,7 +804,7 @@ The command \\[yank] can retrieve it from there."
>        (backward-char 6))
>      (goto-char save-pt)
>      (unless (assq 'the-language modes)
> -      (let ((lang (assoc major-mode calc-language-alist)))
> +      (let ((lang (cl-assoc-if #'derived-mode-p calc-language-alist)))
>          (if lang
>              (setq modes (cons (cons 'the-language (cdr lang))
>                                modes)))))
> <snip>

At first sight: neither calc, viper, nor align use cl-lib, so these
changes break things.



       reply	other threads:[~2017-04-06  1:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170405221727.14496.89482@vcs0.savannah.gnu.org>
     [not found] ` <20170405221729.6CD8B210A4@vcs0.savannah.gnu.org>
2017-04-06  1:39   ` Mark Oteiza [this message]
2017-04-06  3:05     ` master 089b159 02/12: change calc to use derived-mode-p Tom Tromey
2017-04-06  3:25       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871st648mo.fsf@holos \
    --to=mvoteiza@udel.edu \
    --cc=emacs-devel@gnu.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.