From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Daniel P Gomez <gomez.danp@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Have SRC_BLOCK :padline accept numbers
Date: Tue, 18 Apr 2017 10:37:53 +0200 [thread overview]
Message-ID: <871ssq157i.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAJTMgxgwF=MjdpbtUNJtWnaKcJm9Y64g3uMYjT5fJ2+6Oj=CUw@mail.gmail.com> (Daniel P. Gomez's message of "Wed, 29 Mar 2017 18:03:12 +0200")
Hello,
Daniel P Gomez <gomez.danp@gmail.com> writes:
> I've amended the commit including the changes you've mentioned.
> I did not change the following, though:
>
> (numberp (string-to-int padlines)) -> (string-match-p "\\`[0-9]+\\'" padlines)
>
> because that changed the behaviour of org-babel-tangle. Having a
> string-match-p as a
> match condition broke the default of adding no padlines in the
> first tangled SRC block (when passed with no arguments).
`string-to-int' will fail the same way as `string-match-p' if `padlines'
is nil. So I do not see how the behaviour could differ. Could you
elaborate on the issue?
> I also noticed that adding this functionality to ob-tangle breaks eldoc
> for me. I guess all org babel header arguments have to be strings?
I didn't check, but that seems a reasonable assumption.
BTW, you didn't include the patch, did you?
Regards,
--
Nicolas Goaziou 0x80A93738
prev parent reply other threads:[~2017-04-18 9:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 19:47 Have SRC_BLOCK :padline accept numbers Daniel P Gomez
2017-03-29 12:27 ` Nicolas Goaziou
2017-03-29 16:03 ` Daniel P Gomez
2017-03-30 7:50 ` Nicolas Goaziou
2017-04-18 8:37 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ssq157i.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=gomez.danp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.