From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?utf-8?Q?G=C3=B6ktu=C4=9F_Kayaalp?= Newsgroups: gmane.emacs.help Subject: Re: Build failure caused by a .tit file Date: Tue, 18 Apr 2017 16:16:12 +0300 Message-ID: <871sspc0v7.fsf@gkayaalp.com> References: <87pogbb06p.fsf@gkayaalp.com> <83efwrdrej.fsf@gnu.org> <87lgqzav0t.fsf@gkayaalp.com> <838tmzdmym.fsf@gnu.org> <87a87ebpjh.fsf@gkayaalp.com> <83shl6cu6i.fsf@gnu.org> <8760i1c2gm.fsf@gkayaalp.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1492521447 14421 195.159.176.226 (18 Apr 2017 13:17:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Apr 2017 13:17:27 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: help-gnu-emacs@gnu.org To: Eli Zaretskii Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Tue Apr 18 15:17:16 2017 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0T0O-0003U9-2y for geh-help-gnu-emacs@m.gmane.org; Tue, 18 Apr 2017 15:17:16 +0200 Original-Received: from localhost ([::1]:41872 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0T0Q-000604-PY for geh-help-gnu-emacs@m.gmane.org; Tue, 18 Apr 2017 09:17:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0Szc-0005ws-Gh for help-gnu-emacs@gnu.org; Tue, 18 Apr 2017 09:16:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d0SzY-0007jk-4E for help-gnu-emacs@gnu.org; Tue, 18 Apr 2017 09:16:28 -0400 Original-Received: from relay2-d.mail.gandi.net ([2001:4b98:c:538::194]:49057) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d0SzR-0007iJ-Pp; Tue, 18 Apr 2017 09:16:17 -0400 Original-Received: from mfilter20-d.gandi.net (mfilter20-d.gandi.net [217.70.178.148]) by relay2-d.mail.gandi.net (Postfix) with ESMTP id 3E125C5A5C; Tue, 18 Apr 2017 15:16:16 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter20-d.gandi.net Original-Received: from relay2-d.mail.gandi.net ([IPv6:::ffff:217.70.183.194]) by mfilter20-d.gandi.net (mfilter20-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id ZB69V0-plXuL; Tue, 18 Apr 2017 15:16:14 +0200 (CEST) X-Originating-IP: 46.2.17.92 Original-Received: from xi.xi (unknown [46.2.17.92]) (Authenticated sender: self@gkayaalp.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 0FEA2C5A43; Tue, 18 Apr 2017 15:16:12 +0200 (CEST) In-Reply-To: <8760i1c2gm.fsf@gkayaalp.com> (=?utf-8?B?IkfDtmt0dcSf?= Kayaalp"'s message of "Tue, 18 Apr 2017 15:41:45 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4b98:c:538::194 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.org gmane.emacs.help:112802 Archived-At: On 2017-04-18 15:41 +0300, G=C3=B6ktu=C4=9F Kayaalp wro= te: > diff --git a/lisp/international/titdic-cnv.el b/lisp/international/titdic= -cnv.el > index 130bc74..6a593e2 100644 > --- a/lisp/international/titdic-cnv.el > +++ b/lisp/international/titdic-cnv.el > @@ -474,7 +474,6 @@ titdic-convert > (with-temp-file (tit-make-quail-package-file-name filename dirname) > (let ((standard-output (current-buffer))) > (with-temp-buffer > - (set-buffer-multibyte nil) > ;; Here we must use `raw-text' instead of `no-conversion' to > ;; enable auto-decoding of eol format (CRLF->LF). > (let ((coding-system-for-read 'raw-text)) A better version of this one is as follows, which removes the complementary set-buffer-multibyte call: diff --git a/lisp/international/titdic-cnv.el b/lisp/international/titdic-c= nv.el index 130bc74..aa6e4f1 100644 --- a/lisp/international/titdic-cnv.el +++ b/lisp/international/titdic-cnv.el @@ -474,7 +474,6 @@ titdic-convert (with-temp-file (tit-make-quail-package-file-name filename dirname) (let ((standard-output (current-buffer))) (with-temp-buffer - (set-buffer-multibyte nil) ;; Here we must use `raw-text' instead of `no-conversion' to ;; enable auto-decoding of eol format (CRLF->LF). (let ((coding-system-for-read 'raw-text)) @@ -504,7 +503,6 @@ titdic-convert (coding-system-change-eol-conversion coding-system 'unix)) (remove-text-properties (point-min) (point-max) '(charset nil))) =20 - (set-buffer-multibyte t) ;; Set point the starting position of the body part. (goto-char (point-min)) (if (not (search-forward "\nBEGIN" nil t)) BTW I did manage to successfully build with this patch applied. Maybe that second call should happen before the first call to the search forward, i.e. just after the let form in the first hunk. Now I get this weird warning, I can report that elsewhere if not expected: Error (initialization): Creation of the default fontsets failed: (error Invalid script or charset name: old-italic) This is from a build of master as of yesterday (edc63bf). I don't get this with 25.1. --gk.