From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Thien-Thi Nguyen Newsgroups: gmane.emacs.devel Subject: Re: Problem committing tests Date: Mon, 29 May 2017 09:10:35 +0200 Message-ID: <871sr8xhn8.fsf@zigzag> References: <87wp90ppu7.fsf@rosalinde> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: blaine.gmane.org 1496042712 3050 195.159.176.226 (29 May 2017 07:25:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 29 May 2017 07:25:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 29 09:25:08 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFF36-0000dI-3e for ged-emacs-devel@m.gmane.org; Mon, 29 May 2017 09:25:08 +0200 Original-Received: from localhost ([::1]:47202 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFF3B-0002Nk-Mm for ged-emacs-devel@m.gmane.org; Mon, 29 May 2017 03:25:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFF2c-0002Ne-Rv for emacs-devel@gnu.org; Mon, 29 May 2017 03:24:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFF2Z-0006pm-OS for emacs-devel@gnu.org; Mon, 29 May 2017 03:24:38 -0400 Original-Received: from mail.agora-net.com ([67.59.132.6]:46716) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dFF2Z-0006pW-Jb for emacs-devel@gnu.org; Mon, 29 May 2017 03:24:35 -0400 Original-Received: from ttn by mail.agora-net.com with local (Exim 4.82) (envelope-from ) id 1dFF2X-000594-Ag for emacs-devel@gnu.org; Mon, 29 May 2017 03:24:33 -0400 Original-Received: from ttn by zigzag.favinet with local (Exim 4.80) (envelope-from ) id 1dFEpG-0007UZ-Ld for emacs-devel@gnu.org; Mon, 29 May 2017 09:10:51 +0200 Mail-Followup-To: emacs-devel@gnu.org In-Reply-To: <87wp90ppu7.fsf@rosalinde> (Stephen Berman's message of "Mon, 29 May 2017 00:40:48 +0200") X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: ttn@gnuvola.org X-SA-Exim-Scanned: No (on mail.agora-net.com); SAEximRunCond expanded to false X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 67.59.132.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215301 Archived-At: --=-=-= Content-Type: text/plain () Stephen Berman () Mon, 29 May 2017 00:40:48 +0200 I wanted to include some tests with the fix for bug#27121 that I just committed to master (d76c007); however, git complained about trailing whitespace in two data files for the tests. This whitespace is part of the file format used by todo-mode.el, so I cannot delete it. I see that the .gitattributes file in the repository lists several test files for which whitespace warnings should be ignored; should I add the todo-mode test data files to the list? Or is there another or better way to tell git to ignore this whitespace and commit the files? I think it would be cool to restructure the process so that the eol ws-requiring data is generated at run-(test-)time from data that has no eol ws. This is more work, but: - It is explicit. - It avoids possible future lossage if the DVCS changes. - It avoids possible future lossage via PEBKAC or ignorance. (Just think, what if that fool ttn fubars this somehow!?) - If the work should happen to be algorithmic (it is, what a surprise! :-D), it could be generalized and re-used. - If it is written well, it could be documented and exported. So, i urge you to put in the effort here, slap your name on it, and bask in the glory of future Q/A chains terminating w/ a time-saving link to righteous code (and relax{ed,ing} docs). IOW, it is good to cope, better to create, best to invest. -- Thien-Thi Nguyen ----------------------------------------------- (defun responsep (query) (pcase (context query) (`(technical ,ml) (correctp ml)) ...)) 748E A0E8 1CB8 A748 9BFA --------------------------------------- 6CE4 6703 2224 4C80 7502 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlkryW8ACgkQZwMiJEyAdQIRiwCgjjCDAAPef41HBM5T0G4lcKk0 ArwAniqGp8xrB9ftK1KCZ/hRJ4c5DITn =Y7Gj -----END PGP SIGNATURE----- --=-=-=--