all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: joaotavora@gmail.com (João Távora)
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Mark Oteiza <mvoteiza@udel.edu>,
	Lele Gaifax <lele@metapensiero.it>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	emacs-devel@gnu.org
Subject: Re: Three Flymake backends Was Re: Two issues with the new Flymake
Date: Mon, 06 Nov 2017 11:08:06 +0000	[thread overview]
Message-ID: <871slbr7ft.fsf@gmail.com> (raw)
In-Reply-To: <531f8110-5207-0e40-aa24-0ddc1abb8c08@yandex.ru> (Dmitry Gutov's message of "Mon, 6 Nov 2017 12:35:15 +0200")

Dmitry Gutov <dgutov@yandex.ru> writes:

> Probably not. Anyway, I didn't see any difference with '--cache false'.
>
Then probably a good idea to do what flycheck does because gremlins.

>> Hey I didn't spend more than 5 minutes with it :-)
>
> However long, I'm glad you did. Now, the version I've sent is pretty
> much working.
>
> Will you push it to emacs-26?

I think you should test it a tiny bit more and then you push it :-)

> Where will it live?

ruby-mode.el so it at least locally shares some code with ruby-flymake.

> How/when will Flymake choose between rubocop-flymake and ruby-flymake?

Flymake can use both at the same time. Just

   (add-hook 'flymake-diagnostic-functions 'ruby-flymake nil t)
   (add-hook 'flymake-diagnostic-functions 'rubocop-flymake nil t)

The user can remove-hook if he wants to.

If rubocop does everything "ruby -w" does and more, then maybe a single
backend. One that uses a ruby-flymake-use-rubocop-if-available
defcustom, and then checks for (executable-find "rubocop").



  reply	other threads:[~2017-11-06 11:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03  9:50 Two issues with the new Flymake Lele Gaifax
2017-11-03 12:33 ` Stefan Monnier
2017-11-03 14:07   ` Lele Gaifax
2017-11-03 16:59     ` João Távora
2017-11-03 17:15       ` Stefan Monnier
2017-11-03 20:17 ` Three Flymake backends Was " João Távora
2017-11-04 15:30   ` Stefan Monnier
2017-11-04 23:17     ` João Távora
2017-11-05 12:50   ` Dmitry Gutov
2017-11-05 12:59     ` João Távora
2017-11-05 13:04       ` Dmitry Gutov
2017-11-05 13:22         ` João Távora
2017-11-05 20:14           ` Dmitry Gutov
2017-11-05 21:05             ` João Távora
2017-11-05 23:56               ` Dmitry Gutov
2017-11-06  9:48                 ` João Távora
2017-11-06 10:35                   ` Dmitry Gutov
2017-11-06 11:08                     ` João Távora [this message]
2017-11-13  0:23                       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871slbr7ft.fsf@gmail.com \
    --to=joaotavora@gmail.com \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=lele@metapensiero.it \
    --cc=monnier@iro.umontreal.ca \
    --cc=mvoteiza@udel.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.