From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#27841: 25.2; Patch for completion-table-with-predicate Date: Tue, 07 Nov 2017 21:30:11 -0500 Message-ID: <871sl95wp8.fsf@users.sourceforge.net> References: <87mv7f6j06.fsf@users.sourceforge.net> <10ad76ff-8e89-d8f2-1278-3fd04845b243@yandex.ru> <874lti4zng.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1510108467 18873 195.159.176.226 (8 Nov 2017 02:34:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 8 Nov 2017 02:34:27 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 27841@debbugs.gnu.org, Dmitry Gutov To: Ryan Thompson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 08 03:34:21 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCGC4-0004dK-Gh for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Nov 2017 03:34:20 +0100 Original-Received: from localhost ([::1]:56656 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCGCB-0003Xa-Gi for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Nov 2017 21:34:27 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52075) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCG8v-0001QG-2a for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2017 21:31:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCG8r-0005z0-Ul for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2017 21:31:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48638) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eCG8r-0005yu-RZ for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2017 21:31:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eCG8r-0008R7-JD for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2017 21:31:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Nov 2017 02:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27841 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27841-submit@debbugs.gnu.org id=B27841.151010822332382 (code B ref 27841); Wed, 08 Nov 2017 02:31:01 +0000 Original-Received: (at 27841) by debbugs.gnu.org; 8 Nov 2017 02:30:23 +0000 Original-Received: from localhost ([127.0.0.1]:57319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCG8F-0008Q9-F8 for submit@debbugs.gnu.org; Tue, 07 Nov 2017 21:30:23 -0500 Original-Received: from mail-io0-f174.google.com ([209.85.223.174]:46104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCG8C-0008Pl-27; Tue, 07 Nov 2017 21:30:20 -0500 Original-Received: by mail-io0-f174.google.com with SMTP id 101so4361756ioj.3; Tue, 07 Nov 2017 18:30:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=UwonurDoA6VqkVV1GCbvt/1ARDFBNIr9lwJU7U4k/Y8=; b=Qzyc8tWDOyquA6pxKJOfCo1oa+RQBPaH7St2bV5qY3t93TOphtTKWT3e7ffVE/1jNk y4wuLklQed1/uDqcCkIGBD3P62DvO/eSK8gWGiwsIjCCbiXZ/7v/e/evOoGxNRFQ5fm1 mEvepwkI+5SEtZZM5c8IqPkVacQYcNVX70nXqlv3/H7EVy4MXlDEgJym2B2N6DENmp0B PJAm3O5ZRJ2HpwxQF8diZ9krzShlkb9w9ao9OH1mDavj/NwxajqVLb8fosTvZBPOrfqS Ukym5t+59DQC6n8J7srmRrxxO2RqaI0ITCs6Sn0B6Xfs+Vb9DOD/mjRfyvDobovFFVhN FrNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=UwonurDoA6VqkVV1GCbvt/1ARDFBNIr9lwJU7U4k/Y8=; b=PfD07zNDh0T0PTapNwaEm1+4q2yrafSmtb71p7p36KAMyz0T99Llaekw8CWdzCUgBf tt6PG8M3tIRHAQbmdBFzLe3epaj/yE2h4aMeUSWXt455KxBmD87q7wxG3Ct4eKuUgRJa E515QBiISqM2saF/2vRrxQiyPZtzRXEHgPPW/5e9IDs+gviIPBFB3LnxeZst+OIF6PGf chpeyN2ZuujL8TCoPd714TQlgx/7aQaHS1QjjyDeAZM8Egs59aQr6HpGOKmcHbnbjuYx wkhxufcY7jE2FXwFOVVjfgKEalRdlP5LKTFkafRWTCl4jKbHXUsFgUNpqUqDBLyy+yhV aYEw== X-Gm-Message-State: AJaThX67D6CE7g6raPDz2n8D8+V3qzvMp5wSU0mWFg6KgQyJw/+JETGR JcUkc4iOO8IBJr8PsMCmCoCoqw== X-Google-Smtp-Source: AGs4zMZaVpKFSsl2gw1oRPQuUFgLU/U3DwzedLcFMcH9rTZqp5D4xqy9u9V/GiMVCkzex/dVTQRVgw== X-Received: by 10.107.222.17 with SMTP id v17mr1054460iog.283.1510108213895; Tue, 07 Nov 2017 18:30:13 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id r65sm1553132ith.1.2017.11.07.18.30.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 Nov 2017 18:30:12 -0800 (PST) In-Reply-To: <874lti4zng.fsf@users.sourceforge.net> (npostavs's message of "Mon, 07 Aug 2017 21:27:31 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139592 Archived-At: tags 27841 fixed close 27841 26.1 quit npostavs@users.sourceforge.net writes: > Ryan Thompson writes: > >> * ../lisp/minibuffer.el (completion-table-with-predicate): Don't >> act as if strict is non-nil when pred2 is nil (Bug#27841). >> * ../test/lisp/minibuffer-tests.el >> (completion-table-with-predicate-test): Add a test for Bug#27841. > > I wonder how you ended up with the ../ prefix on the filenames? >> +(ert-deftest completion-table-with-predicate-test () >> + (cl-letf* ((full-collection >> + ((symbol-function 'no-A) >> + (lambda (x) (not (string-match-p "a" x)))) >> + ((symbol-function 'no-B) >> + (lambda (x) (not (string-match-p "b" x))))) > > It looks to me like things would be simpler with a let instead of > cl-letf, no? I fixed the commit message, changed this to let, and pushed to emacs-26. [1: 255ba01148]: 2017-11-07 21:25:55 -0500 Fix handling of nil PRED2 arg for completion-table-with-predicate https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=255ba01148f69f452937e67feb7af5d4c1466fed