all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Ryan Thompson <rct@thompsonclan.org>
Cc: 27841@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#27841: 25.2; Patch for completion-table-with-predicate
Date: Tue, 07 Nov 2017 21:30:11 -0500	[thread overview]
Message-ID: <871sl95wp8.fsf@users.sourceforge.net> (raw)
In-Reply-To: <874lti4zng.fsf@users.sourceforge.net> (npostavs's message of "Mon, 07 Aug 2017 21:27:31 -0400")

tags 27841 fixed
close 27841 26.1
quit

npostavs@users.sourceforge.net writes:

> Ryan Thompson <rct@thompsonclan.org> writes:
>
>> 	* ../lisp/minibuffer.el (completion-table-with-predicate): Don't
>> 	act as if strict is non-nil when pred2 is nil (Bug#27841).
>> 	* ../test/lisp/minibuffer-tests.el
>> 	(completion-table-with-predicate-test): Add a test for Bug#27841.
>
> I wonder how you ended up with the ../ prefix on the filenames?

>> +(ert-deftest completion-table-with-predicate-test ()
>> +  (cl-letf* ((full-collection

>> +             ((symbol-function 'no-A)
>> +              (lambda (x) (not (string-match-p "a" x))))
>> +             ((symbol-function 'no-B)
>> +              (lambda (x) (not (string-match-p "b" x)))))
>
> It looks to me like things would be simpler with a let instead of
> cl-letf, no?

I fixed the commit message, changed this to let, and pushed to emacs-26.

[1: 255ba01148]: 2017-11-07 21:25:55 -0500
  Fix handling of nil PRED2 arg for completion-table-with-predicate
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=255ba01148f69f452937e67feb7af5d4c1466fed





      reply	other threads:[~2017-11-08  2:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-26 18:36 bug#27841: 25.2; Patch for completion-table-with-predicate Ryan
2017-08-04 22:55 ` npostavs
2017-08-04 23:00   ` Ryan Thompson
2017-08-04 23:10     ` npostavs
2017-08-04 23:11     ` Dmitry Gutov
2017-08-05  6:22       ` Ryan Thompson
2017-08-08  1:27         ` npostavs
2017-11-08  2:30           ` Noam Postavsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871sl95wp8.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=27841@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=rct@thompsonclan.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.