From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.bugs Subject: bug#29692: 24.5; gnus does not remember password change for imap Date: Fri, 15 Dec 2017 00:19:10 -0500 Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos Message-ID: <871sjwmuup.fsf@lifelogs.com> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1513315209 3815 195.159.176.226 (15 Dec 2017 05:20:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 15 Dec 2017 05:20:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 29692-done@debbugs.gnu.org To: Trey Jackson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 15 06:20:05 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePiPl-0000is-Je for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Dec 2017 06:20:05 +0100 Original-Received: from localhost ([::1]:44508 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePiPs-0005HI-NQ for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Dec 2017 00:20:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePiPl-0005HC-SS for bug-gnu-emacs@gnu.org; Fri, 15 Dec 2017 00:20:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePiPi-000351-NI for bug-gnu-emacs@gnu.org; Fri, 15 Dec 2017 00:20:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54016) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ePiPi-00034X-HM for bug-gnu-emacs@gnu.org; Fri, 15 Dec 2017 00:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ePiPi-0005FB-BK for bug-gnu-emacs@gnu.org; Fri, 15 Dec 2017 00:20:02 -0500 Resent-From: Ted Zlatanov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Dec 2017 05:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 29692 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 29692@debbugs.gnu.org, tzz@lifelogs.com, trey_jackson@mentor.com Original-Received: via spool by 29692-done@debbugs.gnu.org id=D29692.151331516020100 (code D ref 29692); Fri, 15 Dec 2017 05:20:01 +0000 Original-Received: (at 29692-done) by debbugs.gnu.org; 15 Dec 2017 05:19:20 +0000 Original-Received: from localhost ([127.0.0.1]:34461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePiP2-0005E8-KS for submit@debbugs.gnu.org; Fri, 15 Dec 2017 00:19:20 -0500 Original-Received: from mail-qk0-f171.google.com ([209.85.220.171]:33692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePiP0-0005Dw-QC for 29692-done@debbugs.gnu.org; Fri, 15 Dec 2017 00:19:19 -0500 Original-Received: by mail-qk0-f171.google.com with SMTP id 63so9055550qke.0 for <29692-done@debbugs.gnu.org>; Thu, 14 Dec 2017 21:19:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to:date :in-reply-to:message-id:user-agent:mime-version; bh=9v4lmYaf2yLvqBZzS6mzKgp6Wtv2K3Ko1FXYvyBAqLQ=; b=myoHdegahXQZwYE+4JjH1bL9kmM0e/4CmWDWAl5bjcTH6MfqTBIU9fMYaajDHA/a+C iOkLyh+0jvb9ORln/Vx36IKKXS2nF2auDgUQx+7XxuCemK5MPhRuimYlfEAx/jwVKEgQ ASqbpwRhLfUgqpXtJC2pl13fmuT0r6bUj7Ik4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:date:in-reply-to:message-id:user-agent:mime-version; bh=9v4lmYaf2yLvqBZzS6mzKgp6Wtv2K3Ko1FXYvyBAqLQ=; b=ShY/gojxXk76UTVtBT1NVnNVLmpZ3gqAquq++5D0tIPmQIjsH3UIEgq0emjgC9Z8bP FjMTK1q3TNOEv5zn7LgFRlu/FDjMD9fmMyMRUyi5lznzUf3bWsTKM46aU0iBuQLGBjuC Q32g7JfgO08yhIJCs2xGdBba4XzdI3cJ4wFLKJz4zwKN1qGGE+zHOUrU0AnOeMgHRKAD UYbJYtFQdGF2gxCSDoISY1p74zmUBVvTGRv8keo+BpdWXapeCHVkP+BGrNwhsJFLe6it y8Ig8CgHjtWtER+CRY7SBVS1qOZble4rq69OUI8NBuzUaXJQjo0NviZMc1NyncQQ1Fdr CXEQ== X-Gm-Message-State: AKGB3mLMEigWU8fsV3390GoE55qqpYN+YC2evXFjnLf3IIc6lH8rctuI bmWHRYygFYlhU3vczai16okqrQYhLk0= X-Google-Smtp-Source: ACJfBou56vJbhQwK+exYoUnm9mXLxkZcySHWojzGU6uqOj7FTU3OBsPdIkneFoIqn/w7+0zZgCTujA== X-Received: by 10.55.212.129 with SMTP id s1mr14590304qks.106.1513315153263; Thu, 14 Dec 2017 21:19:13 -0800 (PST) Original-Received: from flea (c-76-28-41-155.hsd1.ma.comcast.net. [76.28.41.155]) by smtp.gmail.com with ESMTPSA id j4sm3628043qtk.15.2017.12.14.21.19.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Dec 2017 21:19:11 -0800 (PST) X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never In-Reply-To: (Trey Jackson's message of "Wed, 13 Dec 2017 08:52:27 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141092 Archived-At: On Wed, 13 Dec 2017 08:52:27 -0800 Trey Jackson wrote: TJ> this patch changes the code to check the password as well. TJ> the cache ends up storing two passwords (in this case), but it works b/c TJ> when reading the cache the newest password is used: TJ> /usr/local/share/emacs/24.5/lisp/gnus/mail-source.el.gz ~/scratch/mail-source.el TJ> --- - 2017-12-13 08:47:13.425421767 -0800 TJ> +++ /home/tjackson/scratch/mail-source.el 2017-12-13 08:44:51.098076000 -0800 TJ> @@ -1102,7 +1102,7 @@ TJ> ;; remember password TJ> (with-current-buffer buf TJ> (when (and imap-password TJ> - (not (assoc from mail-source-password-cache))) TJ> + (not (member (cons from imap-password) mail-source-password-cache))) TJ> (push (cons from imap-password) mail-source-password-cache))) TJ> ;; if predicate is nil, use all uids TJ> (dolist (uid (imap-search (or predicate "1:*") buf)) Thank you, applied in the emacs-26 branch. Ted