all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ted Zlatanov <tzz@lifelogs.com>
To: Trey Jackson <trey_jackson@mentor.com>
Cc: 29692-done@debbugs.gnu.org
Subject: bug#29692: 24.5; gnus does not remember password change for imap
Date: Fri, 15 Dec 2017 00:19:10 -0500	[thread overview]
Message-ID: <871sjwmuup.fsf@lifelogs.com> (raw)
In-Reply-To: <u27vahain90.fsf@big-bird.wv.mentorg.com> (Trey Jackson's message of "Wed, 13 Dec 2017 08:52:27 -0800")

On Wed, 13 Dec 2017 08:52:27 -0800 Trey Jackson <trey_jackson@mentor.com> wrote: 

TJ> this patch changes the code to check the password as well.
TJ> the cache ends up storing two passwords (in this case), but it works b/c
TJ> when reading the cache the newest password is used:

TJ> /usr/local/share/emacs/24.5/lisp/gnus/mail-source.el.gz ~/scratch/mail-source.el
TJ> --- -	2017-12-13 08:47:13.425421767 -0800
TJ> +++ /home/tjackson/scratch/mail-source.el	2017-12-13 08:44:51.098076000 -0800
TJ> @@ -1102,7 +1102,7 @@
TJ>  	      ;; remember password
TJ>  	      (with-current-buffer buf
TJ>  		(when (and imap-password
TJ> -			   (not (assoc from mail-source-password-cache)))
TJ> +			   (not (member (cons from imap-password) mail-source-password-cache)))
TJ>  		  (push (cons from imap-password) mail-source-password-cache)))
TJ>  	      ;; if predicate is nil, use all uids
TJ>  	      (dolist (uid (imap-search (or predicate "1:*") buf))

Thank you, applied in the emacs-26 branch.

Ted





      reply	other threads:[~2017-12-15  5:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13 16:52 bug#29692: 24.5; gnus does not remember password change for imap Trey Jackson
2017-12-15  5:19 ` Ted Zlatanov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871sjwmuup.fsf@lifelogs.com \
    --to=tzz@lifelogs.com \
    --cc=29692-done@debbugs.gnu.org \
    --cc=trey_jackson@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.