From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Ian Dunn <dunni@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug in Sticky Agendas
Date: Sat, 06 Jan 2018 10:15:10 +0100 [thread overview]
Message-ID: <871sj38i1t.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87incfrj7q.fsf@gnu.org> (Ian Dunn's message of "Fri, 05 Jan 2018 18:15:05 -0500")
Hello,
Ian Dunn <dunni@gnu.org> writes:
> I went ahead and looked into this myself. Looks like the issue is that
> the properties (lprops) are set using symbol properties with
> org-agenda-redo-command, which is buffer-local. However, according to
> the elisp manual (at least for the upcoming 26.1 release), symbol
> properties aren't buffer-local; only the value itself is. Thus, lprops
> are overridden by a new agenda.
>
> I've created the following patch to address this. The symbol property
> is used as a temporary variable, but the actual lprops are stored as
> a buffer-local variable to each agenda buffer.
Thank you. It looks good.
Could you send it again with a proper commit message so I can apply it?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2018-01-06 9:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-31 3:00 Bug in Sticky Agendas Ian Dunn
2018-01-05 23:15 ` Ian Dunn
2018-01-06 9:15 ` Nicolas Goaziou [this message]
2018-01-06 22:35 ` Ian Dunn
2018-01-07 1:11 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sj38i1t.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=dunni@gnu.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.