all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: 30314@debbugs.gnu.org
Subject: bug#30314: Define aliases for window display actions
Date: Mon, 05 Feb 2018 00:30:29 +0200	[thread overview]
Message-ID: <871si0qtfe.fsf@mail.linkov.net> (raw)
In-Reply-To: <87mv0tsnk8.fsf@mail.linkov.net> (Juri Linkov's message of "Wed,  31 Jan 2018 23:52:55 +0200")

> Instead of duplicating the same list of actions in many places
> like in bug#30016:
>
>         (pop-to-buffer buf `((display-buffer--maybe-same-window
>                               display-buffer-reuse-window
>                               display-buffer--maybe-pop-up-frame-or-window
>                               display-buffer-at-bottom)
> 	                     ,(if temp-buffer-resize-mode
> 		                  '(window-height . resize-temp-buffer-window)
> 	                        '(window-height . fit-window-to-buffer))
> 	                     ,(when temp-buffer-resize-mode
> 	                        '(preserve-size . (nil . t)))))
>
> I propose to introduce the concept of display action aliases to group
> several actions under one name and use just this short name where needed.

I realized that aliases can be implemented simply by defining a new
composite action function:

diff --git a/lisp/files.el b/lisp/files.el
index 414eb3f..22d8247 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -3315,15 +3315,7 @@ hack-local-variables-confirm
 
       ;; Display the buffer and read a choice.
       (save-window-excursion
-	(pop-to-buffer buf `((display-buffer--maybe-same-window
-                              display-buffer-reuse-window
-                              display-buffer--maybe-pop-up-frame-or-window
-                              display-buffer-at-bottom)
-	                     ,(if temp-buffer-resize-mode
-		                  '(window-height . resize-temp-buffer-window)
-	                        '(window-height . fit-window-to-buffer))
-	                     ,(when temp-buffer-resize-mode
-	                        '(preserve-size . (nil . t)))))
+	(pop-to-buffer buf '(display-buffer-composite-at-bottom))
 	(let* ((exit-chars '(?y ?n ?\s ?\C-g ?\C-v))
 	       (prompt (format "Please type %s%s: "
 			       (if offer-save "y, n, or !" "y or n")
@@ -6929,15 +6921,7 @@ save-buffers-kill-emacs
            (or (not active)
                (with-displayed-buffer-window
                 (get-buffer-create "*Process List*")
-                `((display-buffer--maybe-same-window
-                   display-buffer-reuse-window
-                   display-buffer--maybe-pop-up-frame-or-window
-                   display-buffer-at-bottom)
-	          ,(if temp-buffer-resize-mode
-		       '(window-height . resize-temp-buffer-window)
-	             '(window-height . fit-window-to-buffer))
-	          ,(when temp-buffer-resize-mode
-	             '(preserve-size . (nil . t))))
+                '(display-buffer-composite-at-bottom)
                 #'(lambda (window _value)
                     (with-selected-window window
                       (unwind-protect
diff --git a/lisp/window.el b/lisp/window.el
index abd1a68..d9a0bc8 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -7360,6 +7360,20 @@ display-buffer-below-selected
 	     (window--display-buffer
 	      buffer window 'reuse alist display-buffer-mark-dedicated)))))
 
+(defun display-buffer-composite-at-bottom (buffer alist)
+  (let ((alist (append alist `(,(if temp-buffer-resize-mode
+		                    '(window-height . resize-temp-buffer-window)
+	                          '(window-height . fit-window-to-buffer))
+	                       ,(when temp-buffer-resize-mode
+	                          '(preserve-size . (nil . t)))))))
+    (or (display-buffer--maybe-same-window buffer alist)
+        (display-buffer-reuse-window buffer alist)
+        (and (if (eq pop-up-frames 'graphic-only)
+	         (display-graphic-p)
+	       pop-up-frames)
+	     (display-buffer-pop-up-frame buffer alist))
+        (display-buffer-at-bottom buffer alist))))
+
 (defun display-buffer-at-bottom (buffer alist)
   "Try displaying BUFFER in a window at the bottom of the selected frame.
 This either reuses such a window provided it shows BUFFER





  reply	other threads:[~2018-02-04 22:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-31 21:52 bug#30314: Define aliases for window display actions Juri Linkov
2018-02-04 22:30 ` Juri Linkov [this message]
2018-02-06 21:42   ` Juri Linkov
2018-02-10 21:55     ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871si0qtfe.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=30314@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.