bug#31107: 26.0.91; insert-file-contents-literally's doc indicates insert-file-contents runs find-file-hook, but it seems untrue

bug#31107: 26.0.91; insert-file-contents-literally's doc indicates insert-file-contents runs find-file-hook, but it seems untrue

[Xu Chunyang]

'C-h S insert-file-contents-literally' indicates 'insert-file-contents'
runs 'find-file-hook'

    -- Function: insert-file-contents-literally filename &optional visit
             beg end replace
        This function works like ‘insert-file-contents’ except that it does
        not run ‘find-file-hook’, 

However, 'insert-file-contents' doesn't run 'find-file-hook'. I test
using the following

    (add-hook 'find-file-hook
              (defun foo ()
                (message-box "Visiting %s" buffer-file-truename)))
    
    (insert-file-contents "/etc/shells")

'foo' is not called by 'insert-file-contents', though 'find-file' runs
the hook as expected.

    (find-file "/etc/shells")

bug#31107: 26.0.91; insert-file-contents-literally's doc indicates insert-file-contents runs find-file-hook, but it seems untrue

[Noam Postavsky]

Xu Chunyang <mail@xuchunyang.me> writes:

> 'C-h S insert-file-contents-literally' indicates 'insert-file-contents'
> runs 'find-file-hook'
>
>     -- Function: insert-file-contents-literally filename &optional visit
>              beg end replace
>         This function works like ‘insert-file-contents’ except that it does
>         not run ‘find-file-hook’, 
          ^^^

I think you just missed the "not".

bug#31107: 26.0.91; insert-file-contents-literally's doc indicates insert-file-contents runs find-file-hook, but it seems untrue

[Noam Postavsky]

Noam Postavsky <npostavs@gmail.com> writes:

> I think you just missed the "not".

Ugh, nevermind, it was me who misread your report.  Sorry for the noise.

bug#31107: 26.0.91; insert-file-contents-literally's doc indicates insert-file-contents runs find-file-hook, but it seems untrue

[Eli Zaretskii]

> From: Xu Chunyang <mail@xuchunyang.me>
> Date: Mon, 09 Apr 2018 16:23:11 +0800
> 
> 'C-h S insert-file-contents-literally' indicates 'insert-file-contents'
> runs 'find-file-hook'
> 
>     -- Function: insert-file-contents-literally filename &optional visit
>              beg end replace
>         This function works like ‘insert-file-contents’ except that it does
>         not run ‘find-file-hook’, 
> 
> However, 'insert-file-contents' doesn't run 'find-file-hook'.

Whoever wrote that meant after-insert-file-functions.  I fixed that,
thanks.

bug#31107: 26.0.91; insert-file-contents-literally's doc indicates insert-file-contents runs find-file-hook, but it seems untrue

[Eli Zaretskii]

Closing.