From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.help Subject: Re: proper use of add-function Date: Tue, 22 May 2018 17:09:19 -0700 Message-ID: <871se3xmfk.fsf@ericabrahamsen.net> References: <87efi3xppf.fsf@ericabrahamsen.net> <87a7srgtco.fsf@web.de> <87603fxnxi.fsf@ericabrahamsen.net> <874lizgs4g.fsf@web.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1527034242 31100 195.159.176.226 (23 May 2018 00:10:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 23 May 2018 00:10:42 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Wed May 23 02:10:38 2018 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLHMT-0007zj-6H for geh-help-gnu-emacs@m.gmane.org; Wed, 23 May 2018 02:10:37 +0200 Original-Received: from localhost ([::1]:58479 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLHOa-0006vd-5l for geh-help-gnu-emacs@m.gmane.org; Tue, 22 May 2018 20:12:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLHO6-0006vL-Hm for help-gnu-emacs@gnu.org; Tue, 22 May 2018 20:12:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLHO3-0006Ua-BW for help-gnu-emacs@gnu.org; Tue, 22 May 2018 20:12:18 -0400 Original-Received: from [195.159.176.226] (port=53022 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fLHO3-0006Tk-4B for help-gnu-emacs@gnu.org; Tue, 22 May 2018 20:12:15 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fLHLt-0007Nw-Co for help-gnu-emacs@gnu.org; Wed, 23 May 2018 02:10:01 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 15 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:sX3Vbhnv7bDWRlaoClOjLZE5mQg= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.org gmane.emacs.help:116827 Archived-At: Michael Heerdegen writes: > Eric Abrahamsen writes: > >> Okay, I see what you and Noam are saying, and in fact what the docstring >> is saying. It's just pretty weird that `add-function' works on >> variables, and `advice-add' works on functions. > > Actually `add-function' works for "places" (including > `symbol-function'), so it's the more general and more low-level tool. > `advice-add' is higher-level and specialized on function names. I guess that's why I kept trying to make this work -- I thought the `symbol-function' place would allow me to apply my advice to 'canonically-space-region. Why doesn't that work?