From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: stardiviner <numbchild@gmail.com>
Cc: org-mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Add support for Babel with Eshell, (updated PATCH)
Date: Sat, 02 Jun 2018 12:16:12 +0200 [thread overview]
Message-ID: <871sdpo5n7.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87r2lr6mzg.fsf@gmail.com> (stardiviner's message of "Fri, 01 Jun 2018 14:26:43 +0800")
Hello,
stardiviner <numbchild@gmail.com> writes:
> Aha, Thanks, Nicolas, I almost forget this patch. That's great!
Speaking of which, there's an issue in
`org-babel-eshell-initiate-session'.
First, it uses (get-buffer (current-buffer)), which is equivalent to
(current-buffer). But, more importantly, it doesn't do anything with it?
So what is the point of the `progn' in that function?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2018-06-02 10:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-22 2:00 [PATCH] Add support for Babel with Eshell, and some questions stardiviner
2018-04-22 2:01 ` stardiviner
2018-04-22 2:31 ` [PATCH] Add support for Babel with Eshell, (updated PATCH) stardiviner
2018-04-23 9:34 ` Nicolas Goaziou
2018-04-23 13:22 ` stardiviner
2018-04-23 21:35 ` Nicolas Goaziou
2018-04-24 2:39 ` stardiviner
2018-04-25 8:31 ` Nicolas Goaziou
2018-04-26 10:53 ` stardiviner
2018-05-02 14:53 ` stardiviner
2018-05-31 21:13 ` Nicolas Goaziou
2018-06-01 6:26 ` stardiviner
2018-06-02 10:16 ` Nicolas Goaziou [this message]
2018-06-04 2:11 ` stardiviner
2018-06-14 19:12 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sdpo5n7.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=numbchild@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.