From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31715: cl-incf and cl-decf error out when passed a nil-valued variable as 'offset' Date: Mon, 04 Jun 2018 20:12:33 -0400 Message-ID: <871sdm851q.fsf@gmail.com> References: <1dff07f6-8da4-4e4c-a700-0bc39d6f2aa6@live.com> <874lii88hy.fsf@gmail.com> <87o9gqw21y.fsf@web.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528157468 22257 195.159.176.226 (5 Jun 2018 00:11:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 5 Jun 2018 00:11:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel , 31715@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 05 02:11:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPzZ1-0005hA-DZ for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Jun 2018 02:11:03 +0200 Original-Received: from localhost ([::1]:42419 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPzb8-0003Oz-9j for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jun 2018 20:13:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPzaz-0003Ot-Sr for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 20:13:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPzaw-0003Op-OJ for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 20:13:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54064) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fPzaw-0003Og-GY for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 20:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fPzaw-0004j8-4X for bug-gnu-emacs@gnu.org; Mon, 04 Jun 2018 20:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Jun 2018 00:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31715 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31715-submit@debbugs.gnu.org id=B31715.152815756318145 (code B ref 31715); Tue, 05 Jun 2018 00:13:02 +0000 Original-Received: (at 31715) by debbugs.gnu.org; 5 Jun 2018 00:12:43 +0000 Original-Received: from localhost ([127.0.0.1]:33728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPzad-0004ia-EB for submit@debbugs.gnu.org; Mon, 04 Jun 2018 20:12:43 -0400 Original-Received: from mail-io0-f177.google.com ([209.85.223.177]:37354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPzab-0004iN-Gs for 31715@debbugs.gnu.org; Mon, 04 Jun 2018 20:12:41 -0400 Original-Received: by mail-io0-f177.google.com with SMTP id s26-v6so1150789ioj.4 for <31715@debbugs.gnu.org>; Mon, 04 Jun 2018 17:12:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=uRy8hXmOzAO0cvhUgffDIJmN0YOHBGMKlrBrTTVYXlQ=; b=dsDlRIIcpxQ+pU/zvwZbUgfbQtryjzWTdOGUHrq3pS4rxjNtGIELkHFzUwLFbtyolq 16CPCPDxKEhhU2E51u6bm6Milpmzrkgpq92hp7yj+bLXp6Hp38LwqKkMMTOm9jJ+NDtf 0ZKDoqJ6r2STnCyVJjaCNQC0UQPczodOV0yi+HoOhw/vmgGL7+CwRkfsigsxb+pIU5HV BDa+UH3tyvT2DWIAaKrwJhws+44zFf34ceCPEuVyjPRLDrsIHrJtw1xEqyj0mVSx0BCy KChzdnvnnFivtOZkRg80l5nCzsDRiS46XUCR5P0vMWcCHbE59TALeF6HQQs7kIf/cITo huVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=uRy8hXmOzAO0cvhUgffDIJmN0YOHBGMKlrBrTTVYXlQ=; b=Kw/SITghTNSJglm7iaDkr9HzuniAfRne2RaqY3085qa2tIttp9X+f0XFRGCKIY6LnA 1m4vIS6MR1C1Lz1p3K/BBOcxl095gL0MlvH6eo+UPZbUPZMuZp1FQk/plnN8KRPpRE6Q xF1fKnAEPDDk1RtxvedOru0ZgUWBOzuaMBPOGkbDtbAgwO1b88iUMryxLgednCXceyR3 eR26fwRP22dGfnhBZESrAilwgdDw1DEtDwyPjS5pK50++WA8ua3Jtk3LRRk+IlLL47fb Ly3/eUB+/vic0Z5PtcVyLbrbdsUUWVQkwUYbTr0qsjgk30oBgvUBKMZS9nrrqshLHr3c vS4Q== X-Gm-Message-State: APt69E2T1gn6xjW4qHxu/TMAL8Lb6XJsDD4i2m3MvCZdM95Pt5dre1za sjjidWqYJ5bS4BduDUlu+hzHPA== X-Google-Smtp-Source: ADUXVKLxQTwRsHbL90ebvxponK9eo7P4sh8PIEFXIDLERKcAU0RMwFtBED1Y8lwxmitOnhO29DS/Hg== X-Received: by 2002:a6b:c309:: with SMTP id t9-v6mr10553169iof.157.1528157555990; Mon, 04 Jun 2018 17:12:35 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e139-v6sm334153ite.1.2018.06.04.17.12.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Jun 2018 17:12:35 -0700 (PDT) In-Reply-To: <87o9gqw21y.fsf@web.de> (Michael Heerdegen's message of "Tue, 05 Jun 2018 01:43:21 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146979 Archived-At: Michael Heerdegen writes: > Noam Postavsky writes: > >> X is an optional macro parameter, so the "optionalness" applies at >> compile time. > > Are you sure we always treat optional macro parameters like this? Do DOCSTRING and DECL count? (defun NAME ARGLIST &optional DOCSTRING DECL &rest BODY) Since they're obviously not evaluated, it doesn't quite feel the same. I couldn't find any other cases of optional parameters in core macros. There is the special form defvar's INITVALUE, but that is treated even more specially, since it distinguishes nil from omitted. >> I think that would approximately double the cost of cl-incf in the >> simple case [...] Actually, checking again, I seem to be wrong about this; the compiler knows to elide the extra test if the increment is a constant expression, so it would only add runtime when incrementing by a computed amount.