From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 33258@debbugs.gnu.org
Subject: bug#33258: inhibit-select-window
Date: Wed, 07 Nov 2018 23:32:07 +0200 [thread overview]
Message-ID: <871s7wzips.fsf@mail.linkov.net> (raw)
In-Reply-To: <5BE2AEDE.1090109@gmx.at> (martin rudalics's message of "Wed, 07 Nov 2018 10:22:38 +0100")
> You cannot do that in a systematical way - 'display-buffer-alist' is
> agnostic of its clients. And don't forget clients of 'vc-diff' who
> might rely on the fact that the latter selects the window chosen.
So to rule out non-interactive callers of vc-diff we need to check
for (eq this-command 'vc-diff)?
But there is a simpler and safer solution that I already mentioned:
to restore an original window in post-command-hook. Or even better
using your new window-state-change-functions: when inhibit-select-window
was found in an alist from display-buffer-alist then check whether
the selected window was changed in an alist of changes provided by
window-state-change-functions and restore an old selected window.
next prev parent reply other threads:[~2018-11-07 21:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-04 21:17 bug#33258: inhibit-select-window Juri Linkov
2018-11-05 9:34 ` martin rudalics
2018-11-05 21:30 ` Juri Linkov
2018-11-06 8:45 ` martin rudalics
2018-11-06 21:59 ` Juri Linkov
2018-11-07 9:22 ` martin rudalics
2018-11-07 21:32 ` Juri Linkov [this message]
2018-11-08 8:52 ` martin rudalics
2018-11-08 21:56 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s7wzips.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=33258@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.