all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Joost Kremers <joostkremers@fastmail.fm>
To: Help Gnu Emacs mailing list <help-gnu-emacs@gnu.org>
Subject: Is it ok to use (redisplay), or should this be left to the experts?
Date: Thu, 10 Jan 2019 21:43:44 +0100	[thread overview]
Message-ID: <871s5ktf9b.fsf@fastmail.fm> (raw)

Hi,

I have a package for distraction-free writing[1], which, among 
other things, activates full screen and sets the text width to a 
user-defined value. There is an option to set the text width as a 
percentage of (window-total-width), which is now causing an issue, 
as reported by a user.[2]

The problem is that although full screen is activated before 
calculating the text width, (window-total-width) still reports the 
window width that existed before full screen was activated. This 
seems to be some sort of race condition, because adding (sleep-for 
2) before calling (window-total-width) solves the issue.

However, I don't want to force a one or two second wait on all my 
users just because in some conditions, on some system, there may 
be a race condition. (I can't reproduce the issue on my own 
computer, for example).

It seems that a call to (redisplay) also does the trick, but I'm 
hesitant to add this, because, well, I'm not sure why, exactly, 
it's just that I'm not entirely sure when, i.e., in what 
circumstances, (redisplay) is meant to be used, what side effects 
to watch out for (in any), etc.

So I guess what I'm asking is whether someone can tell me whether 
(redisplay) is the right way to deal with this issue, or whether 
there is a better way. Or perhaps the user is SOL and needs to do 
some local configuration to get things to behave?

TIA

Joost




Footnotes: 
[1]  https://github.com/joostkremers/writeroom-mode

[2]  https://github.com/joostkremers/writeroom-mode/issues/48

-- 
Joost Kremers
Life has its moments



             reply	other threads:[~2019-01-10 20:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10 20:43 Joost Kremers [this message]
2019-01-10 22:02 ` Is it ok to use (redisplay), or should this be left to the experts? Stefan Monnier
2019-02-11 23:27   ` Joost Kremers
2019-02-12  3:58     ` Stefan Monnier
2019-02-12  8:06       ` Joost Kremers
2019-02-12 14:45         ` Stefan Monnier
2019-01-11  7:24 ` Eli Zaretskii
2019-02-11 23:43   ` Joost Kremers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871s5ktf9b.fsf@fastmail.fm \
    --to=joostkremers@fastmail.fm \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.