From: Alex Branham <alex.branham@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 34419@debbugs.gnu.org
Subject: bug#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el
Date: Mon, 18 Feb 2019 11:17:30 -0600 [thread overview]
Message-ID: <871s453tjp.fsf@gmail.com> (raw)
In-Reply-To: <83va1lm9ar.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 240 bytes --]
On Fri 15 Feb 2019 at 08:10, Eli Zaretskii <eliz@gnu.org> wrote:
> Maybe bind indent-tabs-mode to the value you want when
> running this test.
Sorry for taking a while to respond; the attached patch should fix the issue.
Thanks,
Alex
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-a-conf-mode-test.patch --]
[-- Type: text/x-patch, Size: 1352 bytes --]
From 08027a320721ed52ef92672caf832e089bd7ac25 Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham@gmail.com>
Date: Fri, 15 Feb 2019 07:17:49 -0600
Subject: [PATCH] Fix a conf-mode test
* test/lisp/textmodes/conf-mode-tests.el (conf-test-align-assignments):
Set `conf-assignment-column' and `indent-tabs-mode'.
Bug#34419
---
test/lisp/textmodes/conf-mode-tests.el | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/test/lisp/textmodes/conf-mode-tests.el b/test/lisp/textmodes/conf-mode-tests.el
index 5d79ceec96..33009215bb 100644
--- a/test/lisp/textmodes/conf-mode-tests.el
+++ b/test/lisp/textmodes/conf-mode-tests.el
@@ -29,11 +29,13 @@
(ert-deftest conf-test-align-assignments ()
"Test for `conf-align-assignments'."
(with-temp-buffer
- (insert "foo: bar\nbar: baz")
- (conf-colon-mode)
- (conf-align-assignments)
- (should (equal (buffer-string)
- "foo: bar\nbar: baz"))))
+ (let ((conf-assignment-column 24)
+ indent-tabs-mode)
+ (insert "foo: bar\nbar: baz")
+ (conf-colon-mode)
+ (conf-align-assignments)
+ (should (equal (buffer-string)
+ "foo: bar\nbar: baz")))))
(ert-deftest conf-test-font-lock ()
(with-temp-buffer
--
2.19.2
next prev parent reply other threads:[~2019-02-18 17:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 20:37 bug#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el Alex Branham
2019-02-11 15:51 ` Eli Zaretskii
2019-02-11 22:26 ` Alex Branham
2019-02-15 8:46 ` Eli Zaretskii
2019-02-15 13:26 ` Alex Branham
2019-02-15 14:10 ` Eli Zaretskii
2019-02-18 17:17 ` Alex Branham [this message]
2019-02-18 17:44 ` Eli Zaretskii
2019-02-19 15:52 ` Alex Branham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s453tjp.fsf@gmail.com \
--to=alex.branham@gmail.com \
--cc=34419@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.