From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#34974: 27.0.50; Moving article error with duplicate suppression disabled Date: Sun, 24 Mar 2019 14:07:31 +0000 Message-ID: <871s2wpedf.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="205284"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Eric Abrahamsen , Lars Ingebrigtsen To: 34974@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 24 15:18:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h83wz-000rIZ-2V for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Mar 2019 15:18:13 +0100 Original-Received: from localhost ([127.0.0.1]:56840 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h83wx-0005GV-TF for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Mar 2019 10:18:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h83wn-0004dw-0f for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 10:18:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h83nE-0007e5-NX for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 10:08:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43323) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h83nE-0007di-6c for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 10:08:08 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h83n8-00006o-1S; Sun, 24 Mar 2019 10:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: eric@ericabrahamsen.net, larsi@gnus.org, bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sun, 24 Mar 2019 14:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 34974 X-GNU-PR-Package: emacs,gnus X-Debbugs-Original-To: submit@debbugs.gnu.org X-Debbugs-Original-Xcc: Eric Abrahamsen , Lars Ingebrigtsen Original-Received: via spool by submit@debbugs.gnu.org id=B.1553436466392 (code B ref -1); Sun, 24 Mar 2019 14:08:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Mar 2019 14:07:46 +0000 Original-Received: from localhost ([127.0.0.1]:56864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h83ms-00006G-HD for submit@debbugs.gnu.org; Sun, 24 Mar 2019 10:07:46 -0400 Original-Received: from mail-ed1-f51.google.com ([209.85.208.51]:36720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h83mq-000063-Mz for submit@debbugs.gnu.org; Sun, 24 Mar 2019 10:07:45 -0400 Original-Received: by mail-ed1-f51.google.com with SMTP id e4so5343905edi.3 for ; Sun, 24 Mar 2019 07:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:message-id:date:user-agent:mime-version; bh=8s0giDz+ikWU1NJPRKB5rtk10CW1aTVeeQOTqkD6Cr4=; b=ctLQ3J58ZcPzW79Ww1IiAInODhklhfP/XxuFBOroTPKUndQ1cY0mTFFdJ9j45o/Fh4 eBJ5ISsixdXPkDQQmjbT/5I7YPJ/J9/4GoIPjSXpBMCTbFnJnk4T+kLBjKJhTcWJgA5w bNjEZzacxRWilLOATyZQAyOCoXeNZayxw+gSe5FRy15IsBXoliJ9oFzOQU93v6y3nOaQ gN8fYRGDbuw6dbE2F4jYJuLTUZwP+hrr3MpL4uy6W3I5v2WqErZ1+jv+jBtP/3mwCC5T cSbe1K7gkQUmCYEFY5C18h5loEdw+OGHBYeQH4uleKEscH0l7dU7nRke+uWiUNJjy9ao UrOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:message-id:date:user-agent :mime-version; bh=8s0giDz+ikWU1NJPRKB5rtk10CW1aTVeeQOTqkD6Cr4=; b=Aq5OVF04m36ZxEZoWJMCrKl0uPVyO8FWaLUJkmb1I0fDW9jRzaaV3I1xKiqWxh6yEL n0yQDiIBOYTqhCS2rarUvWP3wc20L+ABmmuvtwF5TyNH+kQ1jpMy9C/swp59uCLV4GBA 9HF4TKDT7V/Jd2y3am6H1ybmI32H2139AepYBgafEQ4pxq9ac07ODMkUHlUx3LTctOHm 5xdmL/6H7HIZCzIv9HnzvmrV9OzK5USLWmbqVhdUPMZVLTv1sTI9poKZ9sP42sA9CXgI RPsKuNRWqvKilKYpexookJOYGioENkwrHPTsQniKtVb6I1Ioa4QXYwR/D1YBaCOYBc+N mctQ== X-Gm-Message-State: APjAAAX+d0wNGxuJAQs3zVbfCtGFsFqW5hchGkES6Fka9PgrkbkAc4dL fdDbvFKEU4Z5S8qlJ2l0KNjtfaPBN1k= X-Google-Smtp-Source: APXvYqwW24m0xPnsVeHxShvQdjZWnj2I44OC4yRhQwF5iPr2YCJYMRG4jvfFbUEMWGMiQYIFwtmMrA== X-Received: by 2002:a17:906:1dd0:: with SMTP id v16mr11374087ejh.204.1553436457633; Sun, 24 Mar 2019 07:07:37 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id h8sm4558217eda.27.2019.03.24.07.07.36 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 24 Mar 2019 07:07:36 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156695 Archived-At: With gnus-suppress-duplicates left at its default value of nil, trying to move an article with 'B m ' gives me the following backtrace: Debugger entered--Lisp error: (wrong-type-argument hash-table-p nil) remhash("" nil) gnus-dup-unsuppress-article(1988) gnus-summary-move-article(nil) funcall-interactively(gnus-summary-move-article nil) call-interactively(gnus-summary-move-article nil nil) command-execute(gnus-summary-move-article) I'm no expert, and I haven't tried reproducing this with a minimal config, but I think gnus-summary-move-article should not call gnus-dup-unsuppress-article when gnus-suppress-duplicates is nil, right? This issue seems to have been uncovered by the switch to hash-tables in bug#33653. Previously, gnus-dup-unsuppress-article called unintern, which would not complain when its second argument gnus-dup-hashtb was nil, even though it probably should have. Patch to follow. Thanks, -- Basil Gnus v5.13 In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2019-03-24 built on thunk Repository revision: dbd6490ad49b0f088d56cdd5f04178bdd62c806a Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 System Description: Debian GNU/Linux buster/sid