all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alex Gramiak <agrambot@gmail.com>
To: Keith David Bershatsky <esq@lawlist.com>
Cc: eliz@gnu.org, dancol@dancol.org, emacs-devel@gnu.org
Subject: Re: NS port: How to debug excessive garbage collection?
Date: Sun, 14 Apr 2019 21:44:41 -0600	[thread overview]
Message-ID: <871s24sziu.fsf@gmail.com> (raw)
In-Reply-To: <m25zrgq8nh.wl%esq@lawlist.com> (Keith David Bershatsky's message of "Sun, 14 Apr 2019 19:55:46 -0700")

Keith David Bershatsky <esq@lawlist.com> writes:

> Thank you, Alex ... I like the idea of not using a Lisp_Object to store the
> various window caches of fake cursors, as this would entirely eliminate the
> garbage collection issues. Inasmuch as this would be my first usage of an array
> in the world of programming, some guidance regarding the best way to initialize
> the array (window cache) would be greatly appreciated.

Sorry, I shouldn't have said to use a C array in this case. A struct
would be better in this case due to the different types involved.

> I saw three types of arrays: an array matching an exact size known in advance;
> an array that is defined with a specified MAX_ROW / MAX_COL (some rows/columns
> may never be used); and, an array using dynamic allocation with malloc, realloc
> and free.

Right.

> Each window cache should be able to handle up to 250 fake cursors.

Is 250 an arbitrary limit?

> How do you recommend that the array for each window cache be initialized?
>
> 1.  int x
> 2.  int fx
> 3.  int y
> 4.  int fy
> 5.  int hpos
> 6.  int vpos
> 7.  int wd
> 8.  int h
> 9.  int cursor_type
> 10. int cursor_width
> 11. double foreground_red
> 12. double foreground_green
> 13. double foreground_blue
> 14. double background_red
> 15. double background_green
> 16. double background_blue
> 17. bool active_p
> 18. int glyph_flavor

To change it to a struct (with a helper struct):

  struct RGB
  {
    double red;
    double green;
    double blue;
  };

  struct multiple_cursor_cache
  {
    int x;
    int fx;
    int y;
    int fy;
    int hpos;
    int vpos;
    int wd;
    int h;
    int cursor_type;
    int cursor_width;
    struct RGB foreground;
    struct RGB background;
    bool active_p;
    int glyph_flavor;
  };

Then you have:

  struct multiple_cursor_cache mc_cache;

and to set elements:

  w->mc_cache.x = x;
  w->mc_cache.foreground.red = red;

To set all elements to zero, one does:

  memset (&variable, 0, sizeof (variable));




  reply	other threads:[~2019-04-15  3:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-15  2:55 NS port: How to debug excessive garbage collection? Keith David Bershatsky
2019-04-15  3:44 ` Alex Gramiak [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-04-16  5:51 Keith David Bershatsky
2019-04-16  2:57 Keith David Bershatsky
2019-04-16  5:26 ` Alex Gramiak
2019-04-15  5:19 Keith David Bershatsky
2019-04-14 19:46 Keith David Bershatsky
2019-04-14 23:31 ` Alex Gramiak
2019-04-14  7:41 Keith David Bershatsky
2019-04-13 18:07 Keith David Bershatsky
2019-04-13 21:41 ` Alex Gramiak
2019-04-14  3:47 ` Daniel Colascione
2019-04-13 16:31 Keith David Bershatsky
2019-04-13 17:02 ` Alex Gramiak
2019-04-13  5:55 Keith David Bershatsky
2019-04-13  6:48 ` Eli Zaretskii
2019-04-11 23:04 Keith David Bershatsky
2019-04-12  9:30 ` Eli Zaretskii
2019-04-11  3:27 Keith David Bershatsky
2019-04-11 14:14 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871s24sziu.fsf@gmail.com \
    --to=agrambot@gmail.com \
    --cc=dancol@dancol.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=esq@lawlist.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.