From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Date: Sat, 27 Apr 2019 11:40:23 +0200 Message-ID: <871s1nss54.fsf@gmx.de> References: <83sgu71b91.fsf@gnu.org> <87sgu79owh.fsf@gmx.de> <987B61DE-48D3-4618-8F0C-E53B794C6D71@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="60218"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35418@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 27 11:41:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hKJpZ-000FX8-13 for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Apr 2019 11:41:13 +0200 Original-Received: from localhost ([127.0.0.1]:57967 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKJpX-0007ik-Qo for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Apr 2019 05:41:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKJpR-0007iX-Kn for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2019 05:41:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hKJpP-0007sn-Kj for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2019 05:41:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49155) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hKJpN-0007s6-Ue for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2019 05:41:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hKJpN-0001Fc-RD for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2019 05:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Apr 2019 09:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15563580504784 (code B ref 35418); Sat, 27 Apr 2019 09:41:01 +0000 Original-Received: (at 35418) by debbugs.gnu.org; 27 Apr 2019 09:40:50 +0000 Original-Received: from localhost ([127.0.0.1]:34466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKJpC-0001F6-9a for submit@debbugs.gnu.org; Sat, 27 Apr 2019 05:40:50 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:41523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKJpA-0001Er-QX for 35418@debbugs.gnu.org; Sat, 27 Apr 2019 05:40:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556358039; bh=WyZ8QPEbA6l8X1DjCmGtvLLa9YgMmhZ80J6gHZICDnI=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=CorawJJU+A2rE85byZyMzwnRVU7tKoF6U4RvwgIZNJwx6v+RZgWJpvEjfMwbCH8q9 jXjJzaTkytxZXHRq+jrJ5o23tYyZ0AHbS3B52rHRydwjUPwOYLCfGOTiTQtvJpvOyK RQL1JkZf0Ju+j73Lztnrj5B5ZddKinmS5OA9XRq4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.86.57.174]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MFKKh-1hZz1421gP-00FkXg; Sat, 27 Apr 2019 11:40:39 +0200 In-Reply-To: <987B61DE-48D3-4618-8F0C-E53B794C6D71@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Fri, 26 Apr 2019 22:46:56 +0200") X-Provags-ID: V03:K1:FZdLFV0QtZkG2ZLf6OpJ9b5Vh0PXlafGwnY1VEQg+ht/JwnBNGI JP+k47MDoboOHpoTgccDFWBp+6+OT9FNJukt3G75lu//XZjFO9F8CSeH6r1ScYBRDAeGabo P7ogeBu8QwM0QCHy7drl0pfw3edJfY4bhdbWQYLTUAh7E4MgiJSsEGO0JjF0dk2QdjBV6O5 YK7pBwayxaCTRW3Hwcu+w== X-UI-Out-Filterresults: notjunk:1;V03:K0:Adim8lkqLVM=:iMnBrhRkdS/DxP1nmPZHrw DttOvyMTrpsklrt+05Fy2xpYiHGVYBBC0z7V/hA0PXL0HLblHLQ9W8911hF5Zbd69YxCgFOV1 sIFAhEyLN3/rMez6za/5KD7RsdamvMmhf+tfUQNVQ6cngFJhPbgXdku19uiikRCVSpdu79jsn Hr3DtR9vv0uY0uhaYK2lanUJg5ojA6b8HIHP9Af6JQbSdOHu/0fkdDVrIreotw6JoHbU8HTV9 vn+x8DyMr58OEk4lOIn+79+pgeGB7L9tjyph5Hau/mu8QKMQNE05jVSuQCdPR4xOIGS/xyaqp j7FUEi/webRZ9ymDC3QFZi29fx772vyuYiYhvHRppdcLEdsMmyzUYRwWeytxzuFNjsLpvqod+ xnFkbLGf32KPUOm65fxUFJHnqJbKWiyD0KoCkx4mN1gQFsokvMEYpulzRx1oryEGJXfUqJidI mbFtMI6BOlZCPTSuKJ6BxH1vRV2173gieyuR0YVCewzudblypQbLVNfKzPF3dMPr06EeVwnWK l+YiMiC7g4ZsHEi6RkU55lpYZROXgpGAD86+eEgvPZR5XnUTUm84C/pvVowH7MYVFuyNg5Oxe 3b2bqtVj+ICjfqq2lQtaK4HWrBjhzUa5zEmpoY+YDnsg97C8aneQu5lhByjhN3We9zAmuMWOt vC7pEeFXV4hsyINtN58anFCE2SYeB2BINtgy+68nt8ZuzZjh40AITkc+JaB+m2V99PCPZi16f D8/8JBwynPD7KMD3d3W4YXSYMVcluvdrfd4bhDAK9B2KFu0nvctTLxiDF8Q96OZU6vXx+OiX X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158338 Archived-At: Mattias Engdeg=C3=A5rd writes: >> Inotify didn't work on mounted directories. I don't know whether this >> has improved. > > By 'work', do you mean receiving notification about changes made by > the same machine or another machine? As far as I know, the NFS > protocol has no means of propagating notifications, in contrast to > SMB. It fires notifications for changes made by the same machine: --8<---------------cut here---------------start------------->8--- ;; "/net/ford/albinus" is a mounted directory. (write-region "foo" nil "/net/ford/albinus/tmp/foo") (inotify-add-watch "/net/ford/albinus/tmp/foo" t (lambda (event) (message "inotify %S" event))) =3D> (3 . 0) (write-region "foo" nil "/net/ford/albinus/tmp/foo") =3D> inotify ((3 . 0) (modify) "/net/ford/albinus/tmp/foo" 0) inotify ((3 . 0) (open) "/net/ford/albinus/tmp/foo" 0) inotify ((3 . 0) (modify) "/net/ford/albinus/tmp/foo" 0) inotify ((3 . 0) (close-write) "/net/ford/albinus/tmp/foo" 0) --8<---------------cut here---------------end--------------->8--- If I make a modification on the remote machine, nothing happens: --8<---------------cut here---------------start------------->8--- ;; Remote "/ssh:ford:/share/albinus" is the same as local "/net/ford/albinu= s". (write-region "foo" nil "/ssh:ford:/share/albinus/tmp/foo") --8<---------------cut here---------------end--------------->8--- >> What might be an alternative is to let the user decide. If we provide a >> user option `auto-revert-dont-poll', a user could set it to t, and would >> live with the consequences. If she tries to enable autorevert for a >> mounted directory, which is not covered by file notifications, she might >> be surprised. > > That is a possibility, although I'm generally not too fond of > user-adjustable behaviour of this sort. If I understand you right, you > propose that the default value should be 'always poll'? The policy in Emacs is to set the default value to be compatible with previous behavior. If time passes, and we see no drawback, the default value could be changed. Usually, the next major E,acs version . > I would prefer the default to be 'avoid polling' -- I doubt that > malfunctions will be common or serious if they occur -- but I suppose > it is better than the status quo. Yes. Best regards, Michael.