From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Date: Mon, 13 May 2019 15:35:27 +0200 Message-ID: <871s12jx40.fsf@gmx.de> References: <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> <835zqli55l.fsf@gnu.org> <877eazx2xd.fsf@gmx.de> <878svcjbxb.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="156624"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35418@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 13 15:55:36 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQBQW-000eZg-8K for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 May 2019 15:55:36 +0200 Original-Received: from localhost ([127.0.0.1]:57761 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQBQV-00079r-7B for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 May 2019 09:55:35 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60122) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQBMe-0003qb-Qy for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 09:51:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQB7a-0008NX-He for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 09:36:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59156) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQB7a-0008Lh-3T for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 09:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hQB7Z-0001vo-Pb for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 09:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 May 2019 13:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15577545407393 (code B ref 35418); Mon, 13 May 2019 13:36:01 +0000 Original-Received: (at 35418) by debbugs.gnu.org; 13 May 2019 13:35:40 +0000 Original-Received: from localhost ([127.0.0.1]:44467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQB7E-0001vB-D0 for submit@debbugs.gnu.org; Mon, 13 May 2019 09:35:40 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:33683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQB7C-0001uz-Tp for 35418@debbugs.gnu.org; Mon, 13 May 2019 09:35:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1557754530; bh=muctPvQsKeliEiRjmyk7KUE/lm8XiXXiOap+Lhln2wY=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=GE0jrUbm1/NYY+yJlqu6SjQekoViDN0q+KU36EiU8NkhNXiZV4bN8MJ2179ktEQmF rFz2mQOJUYl2+057CkB1bzAonhkjI1CVaUac6jxS95Ilhf33cNmC/xWctdueXCxlDy gYItHhQCc0Z7VrnwLl8p7s5S9oIF6izXMI23my98= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.91.238.102]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LjIit-1gqIvu3rO3-00daAF; Mon, 13 May 2019 15:35:30 +0200 In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Sun, 12 May 2019 21:49:33 +0200") X-Provags-ID: V03:K1:oY6yIUrs9H3Bc6eBTDGR3MMt5JRixYHftK+PEYevPjrK9RXNt3P kZxR8FhadxqAnQgSST6R9jht8/oETYY/tkLt3MzjZPXQg3PBRfreBiSmU9RNFDn6Q65xJyd H86PuMqS5Newg3unucOcf42h53oa3WjGEYHlcyg7l3GQ3IcEbPM3gik7OTEMUQJ+Rdb98IV 31ZlYuLFrH7JTpfkpdCHQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:/Gsd7YEkFyU=:1WFT1sddzhCQd8y8GbnYSw 4hilsLxmoNvcJAxZ5t7q8+GVKl43uu5eeldaM5VHON2DnVErCGj5GedBYa5OaucmVNfx1hEuw /Chr8O3Kmk0Htf6zeUlYMcUJ8ZvFrF/SDgbcrcgH1Wo3G2lpunLAj49fLL5zdLfw1RiZRVHsk OoBzCOsHcicI0TAH51L6NyhTzzuUIa/B0mH+Hu/UbxAucn/GbltWTrmaJBG0zR0rBdFXvH3gp AZtERubVKnlN9AjVEiL7jUJ9nch5Hab9SAGVGCor9kkoOXv9L+Cx0hF7DRVQPnh9odOX5GOgt dBhwt45ZUm5nIj8C0AyztK7hy+9LIXoLmHCCZfhmuG6/wR6csidHVk92HORgOYgoi2J8dzkTD IPgMQAR+hdqlwhCZaZuOB9z5/6LNV3C9g6JOXnQs3w/zh4SeLqQBsN9iyiCu7wcaKC67Gb2+6 6mOjY9pnhhgFXoNTO9hrtTa1syto2ovM0gIxpK42GSIFhqZrqaItvpkm4r/qc5cLibTDCRnuo XbPb/X8Ju6ceJGOrrDefvMdoM03J+P53GhkUf2A34g173aV+gH+RynIGts8AMJEqoQ9pPmyfW ROK3B5WUW7pZ75Ofgp1DHQHQuPmJ7po7gtYyNQgzItXms0LOZyPY+8ClUadbE+RxEp07p/Ugj tzCeSFcFSnxB1gh8mz6+j8PB/s/GLr7ENgTGnmqJIn4hsS2zxGpVgjAGDp4e/5NSHkXbKeuqE Vx8L4NxJu6+VyupzWcxaHAKJ7jxeH/wzCy+l/7j8mrvplkueBvOjfZoveobId/dCoVCG8fQD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159178 Archived-At: Mattias Engdeg=C3=A5rd writes: Hi Mattias, > --- a/doc/emacs/arevert-xtra.texi > +++ b/doc/emacs/arevert-xtra.texi >=20=20 > +@vindex buffer-auto-revert-by-notification > +Some non-file buffers can be updated reliably by file notification on > +their default directory. This can be indicated by setting > +@code{buffer-auto-revert-by-notification} to a non-@code{nil} value in > +that buffer, allowing Auto Revert to avoid periodic polling. Such > +notification does not include changes to files in that directory, only > +to the directory itself. Do we want to say that this is related to a major mode in general? That means, that the mode function shall set this variable. And do we want to mention dired-mode as example? =20=20 > --- a/etc/NEWS > +++ b/etc/NEWS >=20=20 > +*** New variable 'buffer-auto-revert-by-notification' > +Non-file buffers can explicitly declare that notification on their > +default-directory is sufficient to know when updates are required by > +setting the new variable `buffer-auto-revert-by-notification' to a > +non-nil value in that buffer. Auto Revert mode can use this > +information to avoid polling the buffer periodically when > +'auto-revert-avoid-polling' is non-nil. Same remark. Mention major mode dependency. Otherwise, the patch LGTM. Best regards, Michael.