From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Simplify Gnus buffer liveness checking and killing Date: Mon, 20 May 2019 15:48:00 -0700 Message-ID: <871s0swxnj.fsf@ericabrahamsen.net> References: <87ef4uq92p.fsf@tcd.ie> <87woikx0mb.fsf@ericabrahamsen.net> <87d0kcrcp0.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="5162"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 21 00:48:18 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hSr4r-0001D5-6Z for ged-emacs-devel@m.gmane.org; Tue, 21 May 2019 00:48:17 +0200 Original-Received: from localhost ([127.0.0.1]:43076 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSr4q-0007Qf-0b for ged-emacs-devel@m.gmane.org; Mon, 20 May 2019 18:48:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSr4j-0007QM-HA for emacs-devel@gnu.org; Mon, 20 May 2019 18:48:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSr4i-0002fY-AX for emacs-devel@gnu.org; Mon, 20 May 2019 18:48:09 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:39082 helo=mail.ericabrahamsen.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hSr4i-0002fJ-7Q for emacs-devel@gnu.org; Mon, 20 May 2019 18:48:08 -0400 Original-Received: from localhost (50-251-205-17-static.hfc.comcastbusiness.net [50.251.205.17]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id D4BF0FA345; Mon, 20 May 2019 22:48:05 +0000 (UTC) In-Reply-To: <87d0kcrcp0.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 20 May 2019 23:19:39 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 52.70.2.18 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236824 Archived-At: "Basil L. Contovounesios" writes: > Eric Abrahamsen writes: > >> "Basil L. Contovounesios" writes: >> >>> There seems to be overlap in the implementations and usage of >>> gnus-buffer-exists-p and gnus-buffer-live-p, as well as of gnus-buffers >>> and gnus-prune-buffers. >>> >>> The attached patch removes gnus-buffer-exists-p in favour of a modified >>> gnus-buffer-live-p, aliases gnus-prune-buffers to a simplified >>> gnus-buffers, and simplifies several call sites pertaining to buffer >>> liveness checking and killing. WDYT? >> >> I've been running this most of today; nothing terrible has happened so >> far. > > Thanks for testing. > >> Can I suggest adding `gnus-buffer-exists-p' back in as a >> `define-obsolete-function-alias' for `gnus-buffer-live-p'? > > Drats, I was hoping to get away with that one. ;) Nope, there'll always be someone to complain :) >> I assume that will work for macros. > > Yes, so long as the macroexpansion sites are recompiled. > >> Anyway, it would just be nicer for people who, ahem, have external >> packages that were using that function. > > I could have sworn I checked GNU ELPA before removing it... Probably > got mixed up with some other branch I had on the back-burner, sorry. No worries! Looks like my gnorb package was the only one using it, anyway.