From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 33992-done@debbugs.gnu.org
Subject: bug#33992: 27.0.50; xref-find-definitions wastes too much space
Date: Tue, 28 May 2019 23:35:16 +0300 [thread overview]
Message-ID: <871s0ifj1k.fsf@mail.linkov.net> (raw)
In-Reply-To: <437558cf-3bd5-a6c7-e9d7-d22a87064d78@yandex.ru> (Dmitry Gutov's message of "Thu, 16 May 2019 01:37:53 +0300")
>> A patch is proposed in a separate bug#35737.
I'm closing this request because now xref is customizable enough.
And we have no more opinions for changing the default behavior.
FWIW, this is what I currently use to customize xref-find-definitions
to act more like Completions:
(custom-set-variables
'(display-buffer-alist
'((display-buffer-to-xref-p display-buffer-in-direction
(direction . below)
(window-height . fit-window-to-buffer)))))
(defun display-buffer-to-xref-p (buffer-name _action)
(and (string-match-p "\\`\\*\\(xref\\)\\*\\(\\|<[0-9]+>\\)\\'"
buffer-name)
(memq this-command '(xref-find-definitions))))
(with-eval-after-load 'xref
(defvar xref--original-command nil)
(advice-add 'xref-find-definitions :after
(lambda (&rest _args)
(with-current-buffer (window-buffer)
(setq-local xref--original-command 'xref-find-definitions))))
(define-key xref--button-map [(control ?m)]
(lambda ()
(interactive)
(if (memq xref--original-command '(xref-find-definitions))
(call-interactively 'xref-quit-and-goto-xref)
(setq xref--original-window nil)
(call-interactively 'xref-goto-xref)))))
next prev parent reply other threads:[~2019-05-28 20:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-05 23:43 bug#33992: 27.0.50; xref-find-definitions wastes too much space Juri Linkov
2019-01-06 11:03 ` João Távora
2019-03-20 21:37 ` Juri Linkov
2019-03-20 23:23 ` João Távora
2019-04-04 0:02 ` Dmitry Gutov
2019-04-04 20:49 ` Juri Linkov
2019-04-04 23:06 ` Dmitry Gutov
2019-04-05 9:44 ` Felician Nemeth
2019-04-05 23:20 ` Dmitry Gutov
2019-04-06 21:08 ` Juri Linkov
2019-04-06 21:03 ` Juri Linkov
2019-05-02 23:05 ` Dmitry Gutov
2019-05-15 20:57 ` Juri Linkov
2019-05-15 22:37 ` Dmitry Gutov
2019-05-28 20:35 ` Juri Linkov [this message]
2019-06-10 0:35 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s0ifj1k.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=33992-done@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.