From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#14502: 24.3; dired-load-hook should not be customizable Date: Thu, 15 Aug 2019 18:29:32 -0700 Message-ID: <871rxlsxs3.fsf@mouse.gnus.org> References: <87k3mirl7x.fsf@sc3d.org> <8736i32g5y.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="159826"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 14502@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 16 03:30:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hyR4K-000fQY-G6 for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Aug 2019 03:30:16 +0200 Original-Received: from localhost ([::1]:48332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyR4I-0005gv-Mf for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Aug 2019 21:30:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56166) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyR48-0005gW-Ch for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 21:30:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyR47-0001oT-6B for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 21:30:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43965) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hyR47-0001oP-3G for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 21:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hyR46-0004rf-SU for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 21:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Aug 2019 01:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14502 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 14502-submit@debbugs.gnu.org id=B14502.156591898418649 (code B ref 14502); Fri, 16 Aug 2019 01:30:02 +0000 Original-Received: (at 14502) by debbugs.gnu.org; 16 Aug 2019 01:29:44 +0000 Original-Received: from localhost ([127.0.0.1]:52786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyR3m-0004qg-Ay for submit@debbugs.gnu.org; Thu, 15 Aug 2019 21:29:42 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:50712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyR3j-0004qX-TS for 14502@debbugs.gnu.org; Thu, 15 Aug 2019 21:29:40 -0400 Original-Received: from [50.225.213.182] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hyR3f-0000TC-Bu; Fri, 16 Aug 2019 03:29:37 +0200 In-Reply-To: (Reuben Thomas's message of "Thu, 15 Aug 2019 09:07:16 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165174 Archived-At: (Please keep the debbugs address in the Cc header.) Reuben Thomas writes: > I'm not sure I understand the problem, and #13870 does not talk about > `find-file-hook'. > > Sorry, that should say #13780. The problem is that add-hook (often in > 3rd-party code) can be in a race with custom.el. > > As far as this bug report goes, if you try to customize dired-load-hook to load > dired-x, it doesn't work. > > Does it matter whether you use `add-hook' or Customize for this > particular hook? Most hooks are customisable, surely, including > `find-file-hook'. > > Yes, and this can cause problems. See #13780. The problem in #13780 is that if you mix add-hook with Customize settings of a hook, then (depending on load order), the Customize value for the hook may overwrite those add-hooks. The solution proposed is that one shouldn't have defcustoms on the hooks one may somehow expect that packages add stuff to. But dired-load-hook doesn't seem like one of those hooks, and if you use Customize to be (load-x) where load-x is (defun load-x () (require 'dired-x)) then surely dired-x will be loaded with dired is loaded? (Not that I've tried myself.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no