all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Stefan Kangas <stefan@marxist.se>
Cc: Reto Zimmermann <reto@gnu.org>,
	6207@debbugs.gnu.org, John Wiegley <johnw@gnu.org>,
	Kevin Ryde <user42@zip.com.au>,
	Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#6207: 23.1; align.el vhdl rules setup
Date: Thu, 26 Sep 2019 13:58:01 +0100	[thread overview]
Message-ID: <871rw3w6xy.fsf@tcd.ie> (raw)
In-Reply-To: <CADwFkm=gw+J+anUs0bJ4HWpfM+6WAfNWbZbASen5GKPqmvx3Vg@mail.gmail.com> (Stefan Kangas's message of "Thu, 26 Sep 2019 13:04:38 +0200")

Stefan Kangas <stefan@marxist.se> writes:

> How about the attached patch?

I haven't followed the discussion, just noticed some minor issues:

>  (defcustom align-dq-string-modes
>    (append align-lisp-modes align-c++-modes align-perl-modes
> -	  '(python-mode))
> +	  '(python-mode 'vhdl-mode))
                        ^
Stray quote?

> +(make-obsolete-variable 'align-vhdl-rules-list "not used" "27.1")
                                                  ^^^^^^^^^^
This produces the following in *Help*:

  This variable is obsolete since 27.1;
  not used

I think "it is no longer used." or similar, with trailing full stop,
would read better.

>  (defun align-set-vhdl-rules ()
>    "Setup the `align-mode-rules-list' variable for `vhdl-mode'."
> +  (define (obsolete nil "27.1"))
      ^^^^^^
declare?

Thanks,

-- 
Basil





  reply	other threads:[~2019-09-26 12:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-18  0:54 bug#6207: 23.1; align.el vhdl rules setup Kevin Ryde
2010-05-19  3:35 ` Stefan Monnier
2010-05-19  9:54   ` John Wiegley
2010-06-01 13:06   ` Reto Zimmermann
2010-06-08  1:53     ` Kevin Ryde
2010-06-08 13:18       ` Reto Zimmermann
2019-09-26 11:04 ` Stefan Kangas
2019-09-26 12:58   ` Basil L. Contovounesios [this message]
2019-09-26 14:15     ` Stefan Kangas
2019-09-26 17:03       ` Basil L. Contovounesios
2019-09-28 11:07         ` Stefan Kangas
2019-10-04 15:14           ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rw3w6xy.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=6207@debbugs.gnu.org \
    --cc=johnw@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=reto@gnu.org \
    --cc=stefan@marxist.se \
    --cc=user42@zip.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.