From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#30219: 27.0.50; (should (equal ...)) bug for string equality Date: Wed, 09 Oct 2019 23:29:15 +0200 Message-ID: <871rvl38wk.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="91845"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 30219@debbugs.gnu.org To: Philipp Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 09 23:42:53 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIJjR-000Nj7-J7 for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 23:42:53 +0200 Original-Received: from localhost ([::1]:59626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIJjP-0005SI-Ai for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 17:42:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49428) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIJX3-0000Jf-7Q for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 17:30:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIJX1-0008OE-40 for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 17:30:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45448) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iIJX0-0008NX-UK for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 17:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iIJX0-0000Z8-Iq for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 17:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Oct 2019 21:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30219 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 30219-submit@debbugs.gnu.org id=B30219.15706565622092 (code B ref 30219); Wed, 09 Oct 2019 21:30:02 +0000 Original-Received: (at 30219) by debbugs.gnu.org; 9 Oct 2019 21:29:22 +0000 Original-Received: from localhost ([127.0.0.1]:54269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIJWL-0000Xg-Rd for submit@debbugs.gnu.org; Wed, 09 Oct 2019 17:29:22 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:44546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIJWK-0000XX-DX for 30219@debbugs.gnu.org; Wed, 09 Oct 2019 17:29:20 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIJWG-0004qV-B0; Wed, 09 Oct 2019 23:29:18 +0200 In-Reply-To: (Philipp's message of "Mon, 22 Jan 2018 23:55:13 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168797 Archived-At: Philipp writes: > Define the following ERT test: > > (ert-deftest foo () > (should (equal "a\xFF" "a\u00FF"))) > > Then run M-x ert. The test triggers an assertion. This is because ERT > incorrectly assumes that two arrays are equal if their lengths and > elements are equal, but that's not the case when comparing unibyte and > multibyte strings. I tried putting (ert-deftest foo () (should (equal "a\xFF" "a\u00FF"))) into one of the test files and I got 1 unexpected results: FAILED foo So I'm not able to reproduce this bug. But the code in question hasn't changed since this was reported, so I'm not sure why I can't reproduce it. Does anybody else see this? ((pred arrayp) (if (/= (length a) (length b)) `(arrays-of-different-length ,(length a) ,(length b) ,a ,b ,@(unless (char-table-p a) `(first-mismatch-at ,(cl-mismatch a b :test 'equal)))) (cl-loop for i from 0 for ai across a for bi across b for xi = (ert--explain-equal-rec ai bi) do (when xi (cl-return `(array-elt ,i ,xi))) finally (cl-assert (equal a b) t)))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no