From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#40401: 28.0.50; M-x landmark not exists, while described in manual Date: Sun, 05 Apr 2020 02:56:17 +0300 Organization: LINKOV.NET Message-ID: <871rp27qla.fsf@mail.linkov.net> References: <86eet69gvx.fsf@protected.rcdrun.com> <87sghkhlhx.fsf@gmail.com> <83d08owxby.fsf@gnu.org> <85wo6wn06l.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="35406"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 40401@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 05 01:59:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jKsh2-00097m-Op for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Apr 2020 01:59:16 +0200 Original-Received: from localhost ([::1]:43124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKsh1-00087X-QI for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Apr 2020 19:59:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47204) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKsgp-00084K-H3 for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2020 19:59:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKsgo-0006CA-GN for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2020 19:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33424) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jKsgo-0006C4-DG for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2020 19:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jKsgo-0001Eb-CE for bug-gnu-emacs@gnu.org; Sat, 04 Apr 2020 19:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Apr 2020 23:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40401 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 40401-submit@debbugs.gnu.org id=B40401.15860447084600 (code B ref 40401); Sat, 04 Apr 2020 23:59:02 +0000 Original-Received: (at 40401) by debbugs.gnu.org; 4 Apr 2020 23:58:28 +0000 Original-Received: from localhost ([127.0.0.1]:44969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKsgG-0001C7-7f for submit@debbugs.gnu.org; Sat, 04 Apr 2020 19:58:28 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:36711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKsgF-0001BT-6M for 40401@debbugs.gnu.org; Sat, 04 Apr 2020 19:58:27 -0400 X-Originating-IP: 91.129.99.85 Original-Received: from mail.gandi.net (m91-129-99-85.cust.tele2.ee [91.129.99.85]) (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 185F4C0002; Sat, 4 Apr 2020 23:58:19 +0000 (UTC) In-Reply-To: <85wo6wn06l.fsf@gmail.com> (Noam Postavsky's message of "Fri, 03 Apr 2020 09:55:30 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178041 Archived-At: > Ah, you removed it in Emacs 26 actually (I didn't find the commit before > because I did a git message search for 'landmark' but you put 'Landmark' > in the commit message. I should add --regexp-ignore-case to log search > commands). Currently I'm working on making hi-lock case-insensitive in bug#40337, and would be interested in ensuring git search case-insensitive as well. When I tried to run M-x vc-log-search RET landmark it found that commit with upper-case 'Landmark' using the command: git --no-pager log --no-color -i --grep=landmark . I wonder if this -i (--regexp-ignore-case) here should use the same logic as in many other search commands: (if (and case-fold-search search-upper-case) (isearch-no-upper-case-p regexp t) case-fold-search) so if there are no upper-case letters, then vc-log-search is case-insensitive, otherwise with upper-case letters case-sensitive? BTW, I use the following nice customization that highlights all found occurrences in the log: ;; Highlight found occurrences in *vc-search-log* output buffer of vc-log-search. ;; Warning: uses Emacs regexps to highlight Git regexp - their syntax might differ! (advice-add 'vc-git-log-search :after (lambda (buffer pattern) (with-current-buffer buffer (vc-run-delayed (highlight-regexp pattern 'hi-yellow))))) and with fixes from bug#40337 it highlighted even 'Landmark'. What I don't know is how to make this feature generally useful. Maybe by adding a new customizable option for vc-git-log-search that when non-nil will highlight the results?