bug#40401: 28.0.50; M-x landmark not exists, while described in manual

bug#40401: 28.0.50; M-x landmark not exists, while described in manual

[Jean Louis]

In the section Amusements, manual describes:

> ‘M-x landmark’ runs a relatively non-participatory game in which a
> robot attempts to maneuver towards a tree at the center of the window
> based on unique olfactory cues from each of the four directions.

Yet M-x landmark does not work



In GNU Emacs 28.0.50 (build 5, x86_64-pc-linux-gnu, X toolkit, cairo version 1.14.8, Xaw3d scroll bars)
 of 2020-03-28 built on protected.rcdrun.com
Repository revision: dceba13ce57ed0cb726e89566197f77359a38d91
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.11907000
System Description: Hyperbola GNU/Linux-libre

Recent messages:
Wrote /home/data1/protected/.emacs.d/games/snake-scores
Use +,-,0 for further adjustment [3 times]
scroll-down-command: Beginning of buffer
Saving file /home/data1/protected/.emacs.d/games/snake-scores...
Wrote /home/data1/protected/.emacs.d/games/snake-scores
next-line: End of buffer
previous-line: Beginning of buffer [17 times]
funcall-interactively: Buffer is read-only: #<buffer *Snake*>
Quit [3 times]
Mark set [3 times]

Configured using:
 'configure --prefix=/package/text/emacs-2020-03-28 --with-modules
 --without-gpm --with-x-toolkit=lucid
 PKG_CONFIG_PATH=/home/data1/protected/GNUstep/Library/Libraries/pkgconfig:/usr/lib/pkgconfig'

Configured features:
XAW3D XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY
INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB
TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS JSON PDUMPER
LCMS2 GMP

Important settings:
  value of $LC_ALL: de_DE.UTF-8
  value of $LANG: de_DE.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Info

Minor modes in effect:
  text-scale-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow hashcash mail-extr emacsbug message rmc puny dired
dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived
epg epg-config gnus-util rmail rmail-loaddefs text-property-search seq
byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils view sort snake
time-date subr-x disp-table pong gamegrid two-column kmacro iso-transl
morse find-func calc-alg calc-ext calc-menu calc calc-loaddefs calc-macs
proced thingatpt help-fns radix-tree help-mode cl-loaddefs cl-lib mpuz
misearch multi-isearch mule-util jka-compr info easymenu face-remap
blackbox tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote threads dbusbind
inotify lcms2 dynamic-setting system-font-setting font-render-setting
cairo x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 124433 8612)
 (symbols 48 10137 1)
 (strings 32 32706 1673)
 (string-bytes 1 836562)
 (vectors 16 12958)
 (vector-slots 8 166372 10272)
 (floats 8 120 155)
 (intervals 56 5414 506)
 (buffers 1000 27))

-- 
Thanks,
Jean Louis

bug#40401: 28.0.50; M-x landmark not exists, while described in manual

[Noam Postavsky]

found 40401 25.1
quit

Jean Louis <bugs@gnu.support> writes:

> In the section Amusements, manual describes:
>
>> ‘M-x landmark’ runs a relatively non-participatory game in which a
>> robot attempts to maneuver towards a tree at the center of the window
>> based on unique olfactory cues from each of the four directions.
>
> Yet M-x landmark does not work

It seems to have been moved to lisp/obsolete [1: 1a2773ac2d] (so for
now, M-x load-library landmark RET M-x landmark does work).  There is a
comment in it saying

    ;; *Note: This package has now moved to elpa.gnu.org.*

Should we remove mention of it from the manual?

[1: 1a2773ac2d]: 2015-07-07 12:32:13 +0200
  * lisp/play/landmark.el: Move to lisp/obsolete/
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1a2773ac2d05c88f9c246ab9fbf0587921000d3a

bug#40401: 28.0.50; M-x landmark not exists, while described in manual

[Eli Zaretskii]

> From: Noam Postavsky <npostavs@gmail.com>
> Date: Fri, 03 Apr 2020 07:11:38 -0400
> Cc: Nicolas Richard <youngfrog@members.fsf.org>, 40401@debbugs.gnu.org
> 
> found 40401 25.1
> quit
> 
> Jean Louis <bugs@gnu.support> writes:
> 
> > In the section Amusements, manual describes:
> >
> >> ‘M-x landmark’ runs a relatively non-participatory game in which a
> >> robot attempts to maneuver towards a tree at the center of the window
> >> based on unique olfactory cues from each of the four directions.
> >
> > Yet M-x landmark does not work
> 
> It seems to have been moved to lisp/obsolete [1: 1a2773ac2d] (so for
> now, M-x load-library landmark RET M-x landmark does work).  There is a
> comment in it saying
> 
>     ;; *Note: This package has now moved to elpa.gnu.org.*
> 
> Should we remove mention of it from the manual?

It's already removed in the manual that comes with Emacs 27.  Or maybe
I'm blind.

bug#40401: 28.0.50; M-x landmark not exists, while described in manual

[Jean Louis]

My version is git 28.0.50, but maybe I was reading info of Emacs
version 25 installed on my system. I guess that is the problem, that I
don't know how to add proper info file to my paths.

Then bug should be closed. 

* Eli Zaretskii <eliz@gnu.org> [2020-04-03 15:47]:
> > From: Noam Postavsky <npostavs@gmail.com>
> > Date: Fri, 03 Apr 2020 07:11:38 -0400
> > Cc: Nicolas Richard <youngfrog@members.fsf.org>, 40401@debbugs.gnu.org
> > 
> > found 40401 25.1
> > quit
> > 
> > Jean Louis <bugs@gnu.support> writes:
> > 
> > > In the section Amusements, manual describes:
> > >
> > >> ‘M-x landmark’ runs a relatively non-participatory game in which a
> > >> robot attempts to maneuver towards a tree at the center of the window
> > >> based on unique olfactory cues from each of the four directions.
> > >
> > > Yet M-x landmark does not work
> > 
> > It seems to have been moved to lisp/obsolete [1: 1a2773ac2d] (so for
> > now, M-x load-library landmark RET M-x landmark does work).  There is a
> > comment in it saying
> > 
> >     ;; *Note: This package has now moved to elpa.gnu.org.*
> > 
> > Should we remove mention of it from the manual?
> 
> It's already removed in the manual that comes with Emacs 27.  Or maybe
> I'm blind.

bug#40401: 28.0.50; M-x landmark not exists, while described in manual

[Noam Postavsky]

notfound 40401 28.0.50
tags 40401 fixed
close 40401 26.1
quit

Eli Zaretskii <eliz@gnu.org> writes:
>
> It's already removed in the manual that comes with Emacs 27.  Or maybe
> I'm blind.

Ah, you removed it in Emacs 26 actually (I didn't find the commit before
because I did a git message search for 'landmark' but you put 'Landmark'
in the commit message.  I should add --regexp-ignore-case to log search
commands).

[2: 1bc4def8ca6]: 2018-03-23 19:08:32 +0300
  More proofreading of the Emacs manual
  [...]* doc/emacs/misc.texi (Amusements): Remove Landmark.
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1bc4def8ca6d9bf9096af8ea3185c428f36b2c5a

bug#40401: 28.0.50; M-x landmark not exists, while described in manual

[Eli Zaretskii]

> Date: Fri, 3 Apr 2020 16:35:02 +0300
> From: Jean Louis <bugs@gnu.support>
> Cc: Noam Postavsky <npostavs@gmail.com>, youngfrog@members.fsf.org,
>   40401@debbugs.gnu.org
> 
> My version is git 28.0.50, but maybe I was reading info of Emacs
> version 25 installed on my system. I guess that is the problem, that I
> don't know how to add proper info file to my paths.

You need to either run 'install-info' for that, or customize
Info-default-directory-list to put the directory you want at the front
of the list.

bug#40401: 28.0.50; M-x landmark not exists, while described in manual

[Juri Linkov]

> Ah, you removed it in Emacs 26 actually (I didn't find the commit before
> because I did a git message search for 'landmark' but you put 'Landmark'
> in the commit message.  I should add --regexp-ignore-case to log search
> commands).

Currently I'm working on making hi-lock case-insensitive in bug#40337,
and would be interested in ensuring git search case-insensitive as well.
When I tried to run

  M-x vc-log-search RET landmark

it found that commit with upper-case 'Landmark' using the command:

  git --no-pager log --no-color -i --grep=landmark .

I wonder if this -i (--regexp-ignore-case) here should use the same
logic as in many other search commands:

  (if (and case-fold-search search-upper-case)
      (isearch-no-upper-case-p regexp t)
    case-fold-search)

so if there are no upper-case letters, then vc-log-search is case-insensitive,
otherwise with upper-case letters case-sensitive?

BTW, I use the following nice customization that highlights all found
occurrences in the log:

  ;; Highlight found occurrences in *vc-search-log* output buffer of vc-log-search.
  ;; Warning: uses Emacs regexps to highlight Git regexp - their syntax might differ!
  (advice-add 'vc-git-log-search :after
              (lambda (buffer pattern)
                (with-current-buffer buffer
                  (vc-run-delayed
                    (highlight-regexp pattern 'hi-yellow)))))

and with fixes from bug#40337 it highlighted even 'Landmark'.

What I don't know is how to make this feature generally useful.
Maybe by adding a new customizable option for vc-git-log-search
that when non-nil will highlight the results?