From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process Date: Tue, 05 May 2020 21:25:51 +0200 Message-ID: <871rnyyyio.fsf@gmx.de> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="14732"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41099@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 05 21:26:33 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jW3D7-0003kh-8K for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 May 2020 21:26:33 +0200 Original-Received: from localhost ([::1]:57612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jW3D6-0006jl-3d for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 May 2020 15:26:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jW3Cc-0006jc-K7 for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 15:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54255) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jW3Cc-0000wo-BI for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 15:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jW3Cc-0004fs-7A for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 15:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 May 2020 19:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41099 X-GNU-PR-Package: emacs Original-Received: via spool by 41099-submit@debbugs.gnu.org id=B41099.158870676117961 (code B ref 41099); Tue, 05 May 2020 19:26:02 +0000 Original-Received: (at 41099) by debbugs.gnu.org; 5 May 2020 19:26:01 +0000 Original-Received: from localhost ([127.0.0.1]:37568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW3Cb-0004fd-E7 for submit@debbugs.gnu.org; Tue, 05 May 2020 15:26:01 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:43367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW3CZ-0004fP-Lg for 41099@debbugs.gnu.org; Tue, 05 May 2020 15:26:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1588706753; bh=kV97ZkVesVVBY1vGeFEjfdFpKFCTCXGOZgbEdaG1yv4=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=GjOlhARhq0wmmRlVsr0GS+8/6Clu0WokMmF5pxxxInQCfoVvP8zzgI3V+bdkMCtp5 +RZMhNOVb3LDO4S4dvndYugQCvm3ti7vlJbK97h2UpZ8MydfhLfPoFsrsPG6N0kW0R bNEN0rg+gXZNIQOCRkLh82lmUgRwcLC1iW83K36k= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.145.136]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mzyuc-1jBc4k3gww-00x3Ai; Tue, 05 May 2020 21:25:52 +0200 In-Reply-To: (Philipp Stephani's message of "Tue, 5 May 2020 21:02:40 +0200") X-Provags-ID: V03:K1:aV5o7/I0PgAdoCbM3xzJn23ve3v6ru3GEkZUC6t2ZAxGM6PTPzO OGHRYlWIoto3z4iC7gSsQkDGd1qC0TIi5EB4RxIDtz5lSXD2Rg6dvJDjl1IkmGZh3B7S4JD 299rPhmIQRWKordQp84rezRVHzmJ6Q/LbIFD1Iwsp7IkBj6iH1TAONDBr8oRB0hPukyb81Q kPGVw+Vzsr3FVCsXThT/A== X-UI-Out-Filterresults: notjunk:1;V03:K0:xFXDyiZjMj4=:gcU/5JgGF1oMVIIPhIAHNK dBdjFBPIa4S8eHz9602WbahIy4n3qqQCWTvzZB/ISht65XgN/m5XYBGIaoWcmHnFLkGEh9x+J zSG6frmB7Yg474vlCDqE+SQxYs944baHzuzoNS+l5HY4CzvBOK4bYi8amndeBukWQZ5LWdGv7 5SltGiR2s/6ANCh6Z/3C1bC3JTVouXGoARDnZE+q/KI+M99kuiiZhVAqbqhIylTIfJrsvFN6q +O2WIngXt1dukfKaXC+5flppwI4BnTDKKTHSBobESrZltacYrUJlIKX+520YGU1KGNgOci/lJ OQzQ8dDKD6n/k6DH+z7vg0R9RYDSXiV1EeXwYnCP4OxSDCMqrj1ShIyecQ/wdHMMTH9cYyNO1 GF3Az068wya8ejD6VFS+5WusAXzOiik8Kb6RQapLH5c3cfOXuOR24ul49VNPsX8KZobi+mror xlg7inNr3OMR23FxryFkoXAriHtclMbOnETC+0x7j56B93CS+w9pYdRV3LAfR6U+dLEoJWjKp mGHXM4g954Pf4vqzTDUPN9YtyGK3pWxCIPvTN+F13NefeI2jCh8zhvqFJrinBnIewzrV6N7VC KK/0Ts2CKtBpu5u7S0iy38eCJBlfOdwUwFeNJL9/jzzvpX0nFgg3ciq/BhTa4yFGJ1FkRuJZV fD+5BSArjPO/RsNGrWiZsBsImzzTE1QrDlQKSuTfjQCWhk5MnNEBfinTGGffjArjv4nqVTCrW XqWJzU2f+oyoi5BAI+cavuYg7JE0tFiA+L0y6oyI5zMkyi7xXB8E9ohAUCTq3meP6w2KtxTD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179767 Archived-At: Philipp Stephani writes: > It looks like `tramp-send-command-and-check' should not just search > for the exit code, but also return it. No, most use cases a simple nil or t is appropriate. Otherwise, you would need to check always (zerop (tramp-send-command-and-check ...)). But in tramp-sh-handle-process-file, it shall return the exit code (indicated by an optional argument). Same for tramp-adb-send-command-and-check, called in tramp-adb-handle-process-file. Best regards, Michael.