From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: 31395511: =?utf-8?Q?=22Don=E2=80=99t?= attempt to modify constant strings" Date: Wed, 03 Jun 2020 22:52:01 +0100 Message-ID: <871rmvn7ge.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="70797"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org, Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 03 23:52:36 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jgbJM-000IMD-E8 for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Jun 2020 23:52:36 +0200 Original-Received: from localhost ([::1]:33218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgbJL-0007OH-Dr for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Jun 2020 17:52:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgbIr-0006tP-Gc for emacs-devel@gnu.org; Wed, 03 Jun 2020 17:52:05 -0400 Original-Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:34775) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgbIq-0000Ts-MX for emacs-devel@gnu.org; Wed, 03 Jun 2020 17:52:05 -0400 Original-Received: by mail-wr1-x434.google.com with SMTP id r7so3977758wro.1 for ; Wed, 03 Jun 2020 14:52:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=pKUUIIn+7GYo2qmQe3fmEOudoB2sSYPavkK7eq9y3vU=; b=sHoKcVUJSzp7eKMijs3ryM9kVq6SneujMGjquG05zOKfFzMuWE20+OYnmhDgKHdwsd X4ZiK77iUJMxxbxLQggtnAgdrfzVhkPwsCHtyE56ylvJoT5TTlyAl8jzK1xOykM/L6Ih pZuEb55cAXGGmEgUWIN7VAGKKlCu6foK9+7OBtq2QdF/RB6W1iixTdAZfmdKQtlOjBrL JS+hepJFn61ix+6n/jmfMM1Pq0ou3mb+5HSWhgXEG8ghle6KwEobA1uUIEH/5LyLzBMv Gl2xIeNexq6lTjS21rJtUzXUt7ydRL+tnbAPnLCNGqi+7dPoJPRJvh5w42rCS4I2lDO/ 6FkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=pKUUIIn+7GYo2qmQe3fmEOudoB2sSYPavkK7eq9y3vU=; b=Bun57Apo7l4qcU+W+w5ZaUPGhop4mbAnKGmPL1bHHZAskZFUxlfqjP2xcK4SuWpEkS fF49yCpfyOh17F7237CeAOGlVgO3V+Ctfc/Vk0yjgEh+yN0oUYlaoByg9qV34EWGlpIF GdKya+P0HZmB+jZq31hySL85guU5CVWriPCzgLk7EbooS1WObhrWb25v8wVaORxUNCNk T0jxaXnMhBfPTrYwzR2EjPxLczujpEL00nXveMk+b6uT5d0lzaEWrJdtH6r0haZkga5X YH+jMbyCRea74Vk6k3sGxw1MdPDANsYHpreqftIkb5vD0M7AoORpeB3ilWZ94km30QCD OcgQ== X-Gm-Message-State: AOAM533aSTq4uVLVw+jIaud30MgkS8BoGNwiAR70SJL1i+B1g7QIf8DO QmGCPx71htm4gOQlRf9+CKY= X-Google-Smtp-Source: ABdhPJzWd+Q9NtTkzmkpHahtnfPLUN/y3v+u01XpJ/hyo+fhhJj7aHSuHRp3d7AOd/+z8za5f+7HTA== X-Received: by 2002:a5d:508e:: with SMTP id a14mr1239738wrt.335.1591221123202; Wed, 03 Jun 2020 14:52:03 -0700 (PDT) Original-Received: from krug ([89.180.148.153]) by smtp.gmail.com with ESMTPSA id q4sm4571226wma.47.2020.06.03.14.52.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2020 14:52:02 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=joaotavora@gmail.com; helo=mail-wr1-x434.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_EXCESS_BASE64=0.979, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251824 Archived-At: Hi Paul, After a lengthy git bisect, I discovered that this commit is responsible for breaking a very big part of my SLY extension, a Common Lisp IDE for Emacs. The reason is this change to make-text-button - (when (stringp beg) - (setq object beg beg 0 end (length object))) + (setq object (copy-sequence beg) beg 0 end (length object))) I don't pretend to understand the reason for the change, but I know it hasn't worked like this for a long time (SLY came about for Emacs 24.3)., I didn't investigate much, but SLY has a lot of (insert (sly-make-action-button "[SOMEBUTTON]" ..)) and sly-make-action-button is (defun sly-make-action-button (label action &rest props) (apply #'sly--make-text-button label nil :type 'sly-action 'action action 'mouse-action action props) label) and sly--make-text-button is (defun sly--make-text-button (beg end &rest properties) "Just like `make-text-button', but add sly-specifics." (apply #'make-text-button beg end 'sly-connection (sly-current-connection) properties)) Not sure where the problem lies but every button inserted by SLY is now just plain text. Maybe you have an alternative formulation that I can apply in SLY, otherwise I'd really appreciate that you could revert or find an alternative to this change Thanks in advance, Jo=C3=A3o