From: "Philip K." <philip@warpmail.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 41619@debbugs.gnu.org
Subject: bug#41619: [PATCH] Mark python-shell-virtualenv-root as safe local variable
Date: Tue, 16 Jun 2020 21:49:44 +0200 [thread overview]
Message-ID: <871rmerdt3.fsf@warpmail.net> (raw)
In-Reply-To: <83eeqe28xt.fsf@gnu.org> (message from Eli Zaretskii on Tue, 16 Jun 2020 20:54:06 +0300)
Eli Zaretskii <eliz@gnu.org> writes:
>> That would make it harder for projects to hide malicious values of
>> python-shell-virtualenv-root, but it's still an attack vector in
>> principle.
>
> Then I don't think I understand how you suggest to fix this.
I don't know either, any directory with a properly configured
dir-locals.el file and a bin/python executable can be exploited if the
user doesn't pay attention in python-mode.
As mentioned above, I agree that the best thing would be to unmark the
variable as safe. I'll try to find out more on how to avoid abitrary
code execution in python, and if there's some way, I would try to
implement it so that the variable can be marked as safe again.
--
Philip K.
next prev parent reply other threads:[~2020-06-16 19:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-30 20:31 bug#41619: [PATCH] Mark python-shell-virtualenv-root as safe local variable Philip K.
2020-06-13 7:42 ` Eli Zaretskii
2020-06-13 17:20 ` Glenn Morris
2020-06-15 18:53 ` Eli Zaretskii
2020-06-16 16:52 ` Philip K.
2020-06-16 17:18 ` Eli Zaretskii
2020-06-16 17:32 ` Philip K.
2020-06-16 17:54 ` Eli Zaretskii
2020-06-16 19:49 ` Philip K. [this message]
2020-06-20 8:47 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rmerdt3.fsf@warpmail.net \
--to=philip@warpmail.net \
--cc=41619@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.