From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#41705: 28.0.50; minibuffer completion of ".../*/*" shouldn't be "...//" Date: Fri, 14 Aug 2020 19:18:01 +0200 Message-ID: <871rk94052.fsf@gnus.org> References: <871rmv5g33.fsf@gmail.com> <83sgfbar7j.fsf@gnu.org> <87bllygbig.fsf@tcd.ie> <87wo4m4rhe.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7040"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , 41705@debbugs.gnu.org, Stefan Monnier To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 14 19:19:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6dME-0001gz-LL for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Aug 2020 19:19:10 +0200 Original-Received: from localhost ([::1]:46026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6dMD-0006Gw-N8 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Aug 2020 13:19:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6dM6-0006Ed-1v for bug-gnu-emacs@gnu.org; Fri, 14 Aug 2020 13:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42190) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6dM5-000799-Og for bug-gnu-emacs@gnu.org; Fri, 14 Aug 2020 13:19:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k6dM5-0001ei-L8 for bug-gnu-emacs@gnu.org; Fri, 14 Aug 2020 13:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Aug 2020 17:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41705 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41705-submit@debbugs.gnu.org id=B41705.15974254946308 (code B ref 41705); Fri, 14 Aug 2020 17:19:01 +0000 Original-Received: (at 41705) by debbugs.gnu.org; 14 Aug 2020 17:18:14 +0000 Original-Received: from localhost ([127.0.0.1]:53736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6dLK-0001dg-0M for submit@debbugs.gnu.org; Fri, 14 Aug 2020 13:18:14 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:43904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6dLI-0001dP-Go for 41705@debbugs.gnu.org; Fri, 14 Aug 2020 13:18:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Yx/DTtO9AIjUCU6PP0pQmf67tQjbzmZLN4dxfneTCwk=; b=B78SJkC1qDspniQ2IA8N5oAtjH sckMYEKpKL5H+hplX3WQIJPMWm60YEKje2VtatkMdmAyRsDFAc0aLFV1iIjz+4OKcSRYW4+52tP5R 5+/5+1u9ybTyvxkZzwKlFIObSR8ff6cnlTxHalpcamMo+CvPmUpwhmQAl4CYJITARL/c=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6dL9-0004YK-5Q; Fri, 14 Aug 2020 19:18:05 +0200 In-Reply-To: <87wo4m4rhe.fsf@gmail.com> (Pip Cet's message of "Thu, 04 Jun 2020 18:26:37 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185143 Archived-At: Pip Cet writes: >> I selectively applied commits onto emacs-26 rather than bisecting, and >> it seems to point to [1]. Paging Stefan. > > Thanks for that! > > I'd actually suspected the same file as well, and started playing around > with the code a little. I'm suspicious of the code in > completion-pcm--optimize-pattern which turns a '(star) pattern into > nil. That's correct as far as which strings qualify as matches, but it's > incorrect because it doesn't survive the completion-pcm--pattern->string > round trip. > > I think we get something closer to Emacs-26 behavior back with this > patch. This was a couple of months ago, but was apparently never applied? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no