From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#38370: 26.2; Confusing message 'Hunk already applied' in diff-mode Date: Thu, 20 Aug 2020 16:54:51 +0200 Message-ID: <871rk1tlj8.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14965"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 38370@debbugs.gnu.org To: ndame Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 20 16:56:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8lz7-0003lM-7R for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Aug 2020 16:56:09 +0200 Original-Received: from localhost ([::1]:37314 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8lz6-0007B4-8n for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Aug 2020 10:56:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8lz0-0007Aq-OF for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 10:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60092) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k8lz0-0004ht-FO for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 10:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k8lz0-0003S0-F8 for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 10:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Aug 2020 14:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38370 X-GNU-PR-Package: emacs Original-Received: via spool by 38370-submit@debbugs.gnu.org id=B38370.159793530713176 (code B ref 38370); Thu, 20 Aug 2020 14:56:02 +0000 Original-Received: (at 38370) by debbugs.gnu.org; 20 Aug 2020 14:55:07 +0000 Original-Received: from localhost ([127.0.0.1]:43400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8ly7-0003QS-82 for submit@debbugs.gnu.org; Thu, 20 Aug 2020 10:55:07 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:58620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8ly5-0003PP-SS for 38370@debbugs.gnu.org; Thu, 20 Aug 2020 10:55:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Fs6h3q8BXn4A3kPsyJHGfQC3tlki1sG3KrnTwa5Wz7Y=; b=aDP/LCkr1I2efVvG0psXv6qu46 io6hBqW9R/y85nS5lyTMkZxiT44ECD6JbQnRZ+7rA4HAl63pqb4rg7p+2AMf9RUQavNW0oGrF5LyR WSM5lKAEOOSA4lj35TnJidHhYdp5rlUg5jFZ0rlDG8ZJTk+c3RtWqn3rdhAf0uKJTuRI=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8lxt-0004iy-BJ; Thu, 20 Aug 2020 16:54:59 +0200 X-Now-Playing: Ved Buens Ende...'s _Written in Waters_: "Coiled In Wings" In-Reply-To: (ndame's message of "Mon, 25 Nov 2019 14:11:30 +0100 (CET)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185703 Archived-At: ndame writes: > Recently I turned on next-error-follow-minor-mode in diff buffers, so > the source context is shown automatically as I move around in the diff > buffer. > > It works well, but after a while I noticed there is always a 'Hunk > already applied' message in the echo area. [...] > I found it confusing, because I was just moving around, I didn't try > to apply anything, so this message wasn't really informative, it > stopped my flow with its unwanted appearance and reference to an other > operation. > > Shouldn't this 'Hunk already applied' message appear only if the user > actually tries to apply something? Yeah, I've always found that messaging to be confusing and worrisome, as if I had entered a command to change the source code instead of just moving around in it. I've now removed it. Looking at the code in diff-mode, as far as I can see, the actual "apply" functions will still output the hunk status. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no