From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#19032: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Date: Tue, 08 Sep 2020 09:59:56 +0100 Message-ID: <871rjcwsmr.fsf@gmail.com> References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9322"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 43120@debbugs.gnu.org, 19032@debbugs.gnu.org, Sean Whitton To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 08 11:01:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFZV0-0002IG-G3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Sep 2020 11:01:10 +0200 Original-Received: from localhost ([::1]:46588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFZUz-0007ec-7e for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Sep 2020 05:01:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40876) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFZUs-0007eN-R0 for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2020 05:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40359) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFZUs-0006Rm-IK for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2020 05:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFZUs-00056F-H9 for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2020 05:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Sep 2020 09:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19032 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 19032-submit@debbugs.gnu.org id=B19032.159955560519462 (code B ref 19032); Tue, 08 Sep 2020 09:01:02 +0000 Original-Received: (at 19032) by debbugs.gnu.org; 8 Sep 2020 09:00:05 +0000 Original-Received: from localhost ([127.0.0.1]:51903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFZTx-00053o-51 for submit@debbugs.gnu.org; Tue, 08 Sep 2020 05:00:05 -0400 Original-Received: from mail-wr1-f51.google.com ([209.85.221.51]:39788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFZTv-00052m-SB; Tue, 08 Sep 2020 05:00:04 -0400 Original-Received: by mail-wr1-f51.google.com with SMTP id a17so18212634wrn.6; Tue, 08 Sep 2020 02:00:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=5NF3WaY49CTzxW8VNecAxLBUKag9T40oxui0434TBic=; b=cKXWeDOqOUf7HLBueFCNHv4XzTrvMSu5S8KIIzZp77J8cVcbQW+eh/CWURaDiNL6kJ PFhPZKYUNJqgmSaOhGiH1l4Ww2Z6KJdcsEh9GrOTaf6EQ36wvdZeXJ4GkarOW4bbOTyL gdHHFLou2geJKETWzkIEw4L4QKcPNUgUOb51WVVHh+6EYiM0T1X3o1prsu0u107PiGI3 ZkYd8Ht+BM0BZVgvBUn1w8OyqXivEg71PkCmfx7qDOTPZuk+IBtePpvmEcS+RMByRfYS yWzEBElLnt8vOTmdOZ+ltzJeETDRhzvWAZuoQNjghlVyesPgjjoY7afTRhQEeh8N7e+i hOyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=5NF3WaY49CTzxW8VNecAxLBUKag9T40oxui0434TBic=; b=ZKNCAtAIRB0Ojz3iOJeJxGDYPhQubt4cE1SHMsDwO8JmF/LF788qrvlII07qaWK4AB TLM1Pq4+ufuRc3qgzpts6SNHtYfYIXH7E1bBvTmHcM1P1j3EeGVoKBdSQ74ps87iU598 fT1PfekGKpw4pSSQS2vARKDw3yLhGxd75U4IzlAC5UwO57ozE1a5viC1MqyK48gOhsFF vGpJkCeUc1g+ZrfZtq9Hrn8ScPlZgDAAmMf834fHW1YxjGajrX9jK5/bN47tJ+tUehuI lzZJjYm6BzbumOS7LE2B5jMCeHLtKpMvmwzdvUjHapLqwVBKHX+eYFmnxCEgxQskqiJR tisw== X-Gm-Message-State: AOAM5301jHBuFOvCx2F39Mz/HXjf30V2QIhAf7+OoB9pz9OelcjVzFtO d0L7VH/MTazmnq4ES8oHGMY= X-Google-Smtp-Source: ABdhPJwsKcdYejkNW+ynUcso3gneGt+Ur9WFeVO5rzii1hfJwlCQQjlhwNO8YaaH0p0td3k4URmwEw== X-Received: by 2002:adf:edd2:: with SMTP id v18mr24932732wro.242.1599555597967; Tue, 08 Sep 2020 01:59:57 -0700 (PDT) Original-Received: from krug ([89.180.149.6]) by smtp.gmail.com with ESMTPSA id u66sm31313271wmg.44.2020.09.08.01.59.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 01:59:57 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Mon, 07 Sep 2020 13:30:38 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187516 Archived-At: Stefan Monnier writes: >> I think something like this is the way to go for a behaviour change such >> as this. > > Looks fine to me. Thanks, pushed. >> + (define-key map (kbd "RET") 'icomplete-ret) > > Maybe use a `remap`ping instead? I did that, too. Jo=C3=A3o